From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBA3C433DF for ; Sat, 11 Jul 2020 20:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EA7620725 for ; Sat, 11 Jul 2020 20:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbgGKUBP (ORCPT ); Sat, 11 Jul 2020 16:01:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:58784 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbgGKUBP (ORCPT ); Sat, 11 Jul 2020 16:01:15 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1juLgN-004ebr-Dy; Sat, 11 Jul 2020 22:01:11 +0200 Date: Sat, 11 Jul 2020 22:01:11 +0200 From: Andrew Lunn To: min.li.xe@renesas.com Cc: richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices Message-ID: <20200711200111.GU1014141@lunn.ch> References: <1594395685-25199-1-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594395685-25199-1-git-send-email-min.li.xe@renesas.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 10, 2020 at 11:41:25AM -0400, min.li.xe@renesas.com wrote: > From: Min Li > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > It will create a debugfs directory called idtptp{x} and x is the ptp index. > Three inerfaces are present, which are cmd, help and regs. help is read > only and will display a brief help message. regs is read only amd will show > all register values. You can get register dumps for free in debugfs if you use regmap. And i2c devices are well supported by regmap. Andrew