From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D4DC433E0 for ; Tue, 14 Jul 2020 00:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3A5621548 for ; Tue, 14 Jul 2020 00:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbgGNAJB (ORCPT ); Mon, 13 Jul 2020 20:09:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbgGNAJA (ORCPT ); Mon, 13 Jul 2020 20:09:00 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A99DAC061755 for ; Mon, 13 Jul 2020 17:09:00 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 30E491298136E; Mon, 13 Jul 2020 17:09:00 -0700 (PDT) Date: Mon, 13 Jul 2020 17:08:59 -0700 (PDT) Message-Id: <20200713.170859.794084104671494668.davem@davemloft.net> To: george.kennedy@oracle.com Cc: kuba@kernel.org, dan.carpenter@oracle.com, dhaval.giani@oracle.com, netdev@vger.kernel.org Subject: Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures From: David Miller In-Reply-To: <1594641537-1288-1-git-send-email-george.kennedy@oracle.com> References: <1594641537-1288-1-git-send-email-george.kennedy@oracle.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Jul 2020 17:09:00 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: George Kennedy Date: Mon, 13 Jul 2020 07:58:57 -0400 > @@ -237,6 +237,8 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf) > > free: > kfree(priv); > + if (ret >= 0) > + ret = -EIO; > return ret; Success paths reach here, so ">= 0" is not appropriate. Maybe you meant "> 0"?