From: Richard Cochran <richardcochran@gmail.com>
To: sundeep subbaraya <sundeep.lkml@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, sgoutham@marvell.com,
Subbaraya Sundeep <sbhatta@marvell.com>,
Aleksey Makarov <amakarov@marvell.com>
Subject: Re: [PATCH v3 net-next 3/3] octeontx2-pf: Add support for PTP clock
Date: Mon, 13 Jul 2020 06:25:57 -0700 [thread overview]
Message-ID: <20200713132557.GA27934@hoboy> (raw)
In-Reply-To: <CALHRZuoVtuHLFjwW_bJsWxVFYN=PYxwsj+YabNH4p=v82u-MVA@mail.gmail.com>
On Mon, Jul 13, 2020 at 11:40:34AM +0530, sundeep subbaraya wrote:
> > > +static int otx2_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)
> > > +{
> > > + struct otx2_nic *pfvf = netdev_priv(netdev);
> > > + struct hwtstamp_config *cfg = &pfvf->tstamp;
> > > +
> >
> > Need to test phy_has_hwtstamp() here and pass ioctl to PHY if true.
> >
> For this platform PHY is taken care of by firmware hence it is not
> possible.
This has nothing to do with the FW. The HW design might include a PHY
or MII time stamping device.
> > SKBTX_IN_PROGRESS may be set by the PHY, so you need to test whether
> > time stamping is enabled in your MAC driver as well.
> >
> In our case PHY will not set it and the pfvf/MAC driver sets it.
That might be true today, but the MAC driver should not prevent the
possibility of using an external time stamping device in the future.
Thanks,
Richard
next prev parent reply other threads:[~2020-07-13 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 13:26 [PATCH v3 net-next 0/3] Add PTP support for Octeontx2 sundeep.lkml
2020-07-09 13:26 ` [PATCH v3 net-next 1/3] octeontx2-af: Support to enable/disable HW timestamping sundeep.lkml
2020-07-09 13:27 ` [PATCH v3 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor sundeep.lkml
2020-07-09 13:27 ` [PATCH v3 net-next 3/3] octeontx2-pf: Add support for PTP clock sundeep.lkml
2020-07-09 16:01 ` Richard Cochran
2020-07-13 6:10 ` sundeep subbaraya
2020-07-13 13:25 ` Richard Cochran [this message]
2020-07-13 15:50 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713132557.GA27934@hoboy \
--to=richardcochran@gmail.com \
--cc=amakarov@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox