From: David Miller <davem@davemloft.net>
To: george.kennedy@oracle.com
Cc: dan.carpenter@oracle.com, kuba@kernel.org,
dhaval.giani@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures
Date: Tue, 14 Jul 2020 14:37:31 -0700 (PDT) [thread overview]
Message-ID: <20200714.143731.1428321936444887200.davem@davemloft.net> (raw)
In-Reply-To: <b7423f65-53d5-35d7-a469-509163c85853@oracle.com>
From: George Kennedy <george.kennedy@oracle.com>
Date: Tue, 14 Jul 2020 17:34:33 -0400
> For example, the failing case here has "ret" = 0 (#define ETH_ALEN 6):
>
> 172 static int ax88172a_bind(struct usbnet *dev, struct
> usb_interface *intf)
> 173 {
> ...
> 186 /* Get the MAC address */
> 187 ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0,
> ETH_ALEN, buf, 0);
> 188 if (ret < ETH_ALEN) {
> 189 netdev_err(dev->net, "Failed to read MAC
> address: %d\n", ret);
> 190 goto free;
> 191 }
> "drivers/net/usb/ax88172a.c"
Then this is the spot that should set 'ret' to -EINVAL or similar?
next prev parent reply other threads:[~2020-07-14 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 11:58 [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures George Kennedy
2020-07-14 0:08 ` David Miller
2020-07-14 8:00 ` Dan Carpenter
2020-07-14 21:03 ` David Miller
2020-07-14 21:34 ` George Kennedy
2020-07-14 21:37 ` David Miller [this message]
2020-07-15 14:01 ` George Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714.143731.1428321936444887200.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=george.kennedy@oracle.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).