From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, simon.horman@netronome.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, thomas.lendacky@amd.com,
aelior@marvell.com, skalluru@marvell.com
Subject: Re: [PATCH net-next 04/12] xgbe: convert to new udp_tunnel_nic infra
Date: Tue, 14 Jul 2020 11:25:41 +0800 [thread overview]
Message-ID: <202007141101.RUZno1Jn%lkp@intel.com> (raw)
In-Reply-To: <20200714003037.669012-5-kuba@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 5104 bytes --]
Hi Jakub,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/udp_tunnel-NIC-RX-port-offload-infrastructure/20200714-083337
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2be53e0e4690a764b6af18536eb78b811f40eacc
config: arc-allyesconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/amd/xgbe/xgbe-drv.c: In function 'xgbe_set_features':
>> drivers/net/ethernet/amd/xgbe/xgbe-drv.c:2234:20: warning: variable 'udp_tunnel' set but not used [-Wunused-but-set-variable]
2234 | netdev_features_t udp_tunnel;
| ^~~~~~~~~~
vim +/udp_tunnel +2234 drivers/net/ethernet/amd/xgbe/xgbe-drv.c
1a510ccf5869a95 Lendacky, Thomas 2017-08-18 2227
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2228 static int xgbe_set_features(struct net_device *netdev,
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2229 netdev_features_t features)
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2230 {
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2231 struct xgbe_prv_data *pdata = netdev_priv(netdev);
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2232 struct xgbe_hw_if *hw_if = &pdata->hw_if;
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2233 netdev_features_t rxhash, rxcsum, rxvlan, rxvlan_filter;
1a510ccf5869a95 Lendacky, Thomas 2017-08-18 @2234 netdev_features_t udp_tunnel;
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2235 int ret = 0;
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2236
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2237 rxhash = pdata->netdev_features & NETIF_F_RXHASH;
801c62d945c6121 Lendacky, Thomas 2014-06-24 2238 rxcsum = pdata->netdev_features & NETIF_F_RXCSUM;
801c62d945c6121 Lendacky, Thomas 2014-06-24 2239 rxvlan = pdata->netdev_features & NETIF_F_HW_VLAN_CTAG_RX;
801c62d945c6121 Lendacky, Thomas 2014-06-24 2240 rxvlan_filter = pdata->netdev_features & NETIF_F_HW_VLAN_CTAG_FILTER;
1a510ccf5869a95 Lendacky, Thomas 2017-08-18 2241 udp_tunnel = pdata->netdev_features & NETIF_F_GSO_UDP_TUNNEL;
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2242
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2243 if ((features & NETIF_F_RXHASH) && !rxhash)
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2244 ret = hw_if->enable_rss(pdata);
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2245 else if (!(features & NETIF_F_RXHASH) && rxhash)
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2246 ret = hw_if->disable_rss(pdata);
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2247 if (ret)
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2248 return ret;
5b9dfe299e55604 Lendacky, Thomas 2014-11-04 2249
801c62d945c6121 Lendacky, Thomas 2014-06-24 2250 if ((features & NETIF_F_RXCSUM) && !rxcsum)
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2251 hw_if->enable_rx_csum(pdata);
801c62d945c6121 Lendacky, Thomas 2014-06-24 2252 else if (!(features & NETIF_F_RXCSUM) && rxcsum)
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2253 hw_if->disable_rx_csum(pdata);
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2254
801c62d945c6121 Lendacky, Thomas 2014-06-24 2255 if ((features & NETIF_F_HW_VLAN_CTAG_RX) && !rxvlan)
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2256 hw_if->enable_rx_vlan_stripping(pdata);
801c62d945c6121 Lendacky, Thomas 2014-06-24 2257 else if (!(features & NETIF_F_HW_VLAN_CTAG_RX) && rxvlan)
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2258 hw_if->disable_rx_vlan_stripping(pdata);
801c62d945c6121 Lendacky, Thomas 2014-06-24 2259
801c62d945c6121 Lendacky, Thomas 2014-06-24 2260 if ((features & NETIF_F_HW_VLAN_CTAG_FILTER) && !rxvlan_filter)
801c62d945c6121 Lendacky, Thomas 2014-06-24 2261 hw_if->enable_rx_vlan_filtering(pdata);
801c62d945c6121 Lendacky, Thomas 2014-06-24 2262 else if (!(features & NETIF_F_HW_VLAN_CTAG_FILTER) && rxvlan_filter)
801c62d945c6121 Lendacky, Thomas 2014-06-24 2263 hw_if->disable_rx_vlan_filtering(pdata);
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2264
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2265 pdata->netdev_features = features;
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2266
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2267 DBGPR("<--xgbe_set_features\n");
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2268
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2269 return 0;
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2270 }
c5aa9e3b815645e Lendacky, Thomas 2014-06-05 2271
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64690 bytes --]
next prev parent reply other threads:[~2020-07-14 3:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 0:30 [PATCH net-next 00/12] udp_tunnel: NIC RX port offload infrastructure Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 01/12] nfp: convert to new udp_tunnel_nic infra Jakub Kicinski
2020-07-14 15:07 ` Simon Horman
2020-07-14 0:30 ` [PATCH net-next 02/12] be2net: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 03/12] xgbe: switch to more generic VxLAN detection Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 04/12] xgbe: convert to new udp_tunnel_nic infra Jakub Kicinski
2020-07-14 3:25 ` kernel test robot [this message]
2020-07-14 0:30 ` [PATCH net-next 05/12] bnx2x: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 06/12] cxgb4: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 07/12] enic: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 08/12] liquidio: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 09/12] liquidio_vf: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 10/12] fm10k: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 11/12] qede: " Jakub Kicinski
2020-07-14 0:30 ` [PATCH net-next 12/12] qlcnic: " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007141101.RUZno1Jn%lkp@intel.com \
--to=lkp@intel.com \
--cc=aelior@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=skalluru@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).