From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BCCC433EC for ; Tue, 14 Jul 2020 14:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2AA0206F5 for ; Tue, 14 Jul 2020 14:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594737771; bh=b/Z340xRhSHG+jhE9yjtrc/GHJ2g+duPU+ouTzebMUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WThuLCHE9N4NMC9PxBbyTkUr9ObbmhB3ggBHU+6aAFFgGiGMIoV8nQbutmg5gMpvR NhuFUCLgipkr8u70F6C5QiArMKWGxk5XXTwTX1JN+E1P9ivGIanVXiqynya1IHvtsY S57ZIhpb31+tP2Z/8PjqYIMshvuSAzbaSGWjP+yY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729578AbgGNOmv (ORCPT ); Tue, 14 Jul 2020 10:42:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:55374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729148AbgGNOjv (ORCPT ); Tue, 14 Jul 2020 10:39:51 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EE432256D; Tue, 14 Jul 2020 14:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594737591; bh=b/Z340xRhSHG+jhE9yjtrc/GHJ2g+duPU+ouTzebMUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mzeyU6SQa8XE2QT2MC8uVh6YHofFKFwEGoXPJRhylJUZHdlNVYz/TjTJtBZhPTjWG iHCWhDCjhq1qU6uFrAes8HWJa2MBnq+tGz+b2ociZWputeXshizJd5lksPjipKFcH4 O0IJsfysVifwo+XMotmM49qtISKDj1364a7ZMdLM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tom Rix , Andrew Lunn , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH AUTOSEL 4.19 11/13] net: sky2: initialize return of gm_phy_read Date: Tue, 14 Jul 2020 10:39:35 -0400 Message-Id: <20200714143937.4035685-11-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714143937.4035685-1-sashal@kernel.org> References: <20200714143937.4035685-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tom Rix [ Upstream commit 28b18e4eb515af7c6661c3995c6e3c34412c2874 ] clang static analysis flags this garbage return drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return v; ^~~~~~~~ static inline u16 gm_phy_read( ... { u16 v; __gm_phy_read(hw, port, reg, &v); return v; } __gm_phy_read can return without setting v. So handle similar to skge.c's gm_phy_read, initialize v. Signed-off-by: Tom Rix Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index d013f30019b69..2452d8ba40730 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -215,7 +215,7 @@ static int __gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg, u16 *val) static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg) { - u16 v; + u16 v = 0; __gm_phy_read(hw, port, reg, &v); return v; } -- 2.25.1