From: Kalle Valo <kvalo@codeaurora.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Xinming Hu <huxinming820@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mwifiex: Fix reporting 'operation not supported' error code
Date: Wed, 15 Jul 2020 09:13:21 +0000 (UTC) [thread overview]
Message-ID: <20200715091321.DE825C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200703112151.18917-1-pali@kernel.org>
Pali Rohár <pali@kernel.org> wrote:
> ENOTSUPP (double PP) is internal linux kernel code 524 available only in
> kernel include file linux/errno.h and not exported to userspace.
>
> EOPNOTSUPP (OP; double PP) is standard code 95 for reporting 'operation not
> supported' available via kernel include file uapi/asm-generic/errno.h.
>
> ENOTSUP (single P) is alias for EOPNOTSUPP defined only in userspace
> include file bits/errno.h and not available in kernel.
>
> Because Linux kernel does not support ENOTSUP (single P) and because
> userspace does not support ENOTSUPP (double PP), report error code for
> 'operation not supported' via EOPNOTSUPP macro.
>
> This patch fixes problem that mwifiex kernel driver sends to userspace
> unsupported error codes like: "failed: -524 (No error information)".
> After applying this patch userspace see: "failed: -95 (Not supported)".
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Acked-by: Ganapathi Bhat <ganapathi.bhat@nxp.com>
Patch applied to wireless-drivers-next.git, thanks.
9187f4e84092 mwifiex: Fix reporting 'operation not supported' error code
--
https://patchwork.kernel.org/patch/11641737/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-07-15 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:21 [PATCH] mwifiex: Fix reporting 'operation not supported' error code Pali Rohár
2020-07-07 7:21 ` [EXT] " Ganapathi Bhat
2020-07-15 9:13 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715091321.DE825C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).