From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6816FC433E1 for ; Wed, 15 Jul 2020 10:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48D1C206F5 for ; Wed, 15 Jul 2020 10:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AmV5+HW7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731263AbgGOKjq (ORCPT ); Wed, 15 Jul 2020 06:39:46 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:11466 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729045AbgGOKjq (ORCPT ); Wed, 15 Jul 2020 06:39:46 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594809585; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=D94aB3iFUbAB03ytvbk1mOfOw9Sr0hPBz1uTT/NFTSU=; b=AmV5+HW7XrC01ICiXtVwQ4jMpTlDG1Q6ZVhCMyCJkV2QZFg1MY75A+WObpU5cJhHYNATiOGq KltQUyuZhsjUuMlELyKPCRIjuvG9X+ceIqI5euzYFxVcql3J9giTTT4cDHzy1w1BQbyj69WN l6GsqkRWT/powkU15460z+PzsNA= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5f0edcf103c8596cdb380812 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Jul 2020 10:39:45 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 691F5C433A0; Wed, 15 Jul 2020 10:39:43 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id EB745C433C9; Wed, 15 Jul 2020 10:39:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EB745C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v1 1/2] ipw2100: use generic power management From: Kalle Valo In-Reply-To: <20200629072525.156154-2-vaibhavgupta40@gmail.com> References: <20200629072525.156154-2-vaibhavgupta40@gmail.com> To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , bjorn@helgaas.com, Vaibhav Gupta , "David S. Miller" , Stanislav Yakovlev , Jakub Kicinski , Vaibhav Gupta , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200715103943.691F5C433A0@smtp.codeaurora.org> Date: Wed, 15 Jul 2020 10:39:43 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Vaibhav Gupta wrote: > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > The driver was invoking PCI helper functions like pci_save/restore_state(), > pci_enable/disable_device() and pci_set_power_state(), which is not > recommended. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta 2 patches applied to wireless-drivers-next.git, thanks. 814db61adb86 ipw2100: use generic power management 77b4ad07699f ipw2200: use generic power management -- https://patchwork.kernel.org/patch/11632343/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches