From: Stefano Garzarella <sgarzare@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, davem@davemloft.net
Cc: davem@davemloft.net, Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer
Date: Wed, 15 Jul 2020 16:34:46 +0200 [thread overview]
Message-ID: <20200715143446.kfl3zb4vwkk4ic4r@steredhat> (raw)
In-Reply-To: <20200713065423-mutt-send-email-mst@kernel.org>
On Mon, Jul 13, 2020 at 06:54:43AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 10, 2020 at 02:12:43PM +0200, Stefano Garzarella wrote:
> > Commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free
> > on the_virtio_vsock") starts to use RCU to protect 'the_virtio_vsock'
> > pointer, but we forgot to annotate it.
> >
> > This patch adds the annotation to fix the following sparse errors:
> >
> > net/vmw_vsock/virtio_transport.c:73:17: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:73:17: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:73:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:171:17: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:171:17: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:171:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:207:17: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:207:17: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:207:17: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:561:13: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:561:13: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:561:13: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:612:9: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:612:9: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:612:9: struct virtio_vsock *
> > net/vmw_vsock/virtio_transport.c:631:9: error: incompatible types in comparison expression (different address spaces):
> > net/vmw_vsock/virtio_transport.c:631:9: struct virtio_vsock [noderef] __rcu *
> > net/vmw_vsock/virtio_transport.c:631:9: struct virtio_vsock *
> >
> > Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock")
> > Reported-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> who's merging this? Dave?
I think so, but I forgot the 'net' tag :-(
I'll wait to see if Dave will queue this, otherwise I'll resend with
the 'net' tag.
Thanks,
Stefano
next prev parent reply other threads:[~2020-07-15 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:12 [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer Stefano Garzarella
2020-07-13 9:28 ` Stefan Hajnoczi
2020-07-13 10:54 ` Michael S. Tsirkin
2020-07-15 14:34 ` Stefano Garzarella [this message]
2020-07-16 0:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715143446.kfl3zb4vwkk4ic4r@steredhat \
--to=sgarzare@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).