From: Christoph Hellwig <hch@lst.de>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Christoph Hellwig <hch@lst.de>, Doug Nazar <nazard@nazar.ca>,
ericvh@gmail.com, lucho@ionkov.net,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+e6f77e16ff68b2434a2c@syzkaller.appspotmail.com
Subject: Re: [PATCH] net/9p: validate fds in p9_fd_open
Date: Wed, 15 Jul 2020 20:19:49 +0200 [thread overview]
Message-ID: <20200715181949.GA31172@lst.de> (raw)
In-Reply-To: <20200715134756.GB22828@nautica>
On Wed, Jul 15, 2020 at 03:47:56PM +0200, Dominique Martinet wrote:
> Christoph Hellwig wrote on Wed, Jul 15, 2020:
> > FYI, this is now generating daily syzbot reports, so I'd love to see
> > the fix going into Linus' tree ASAP..
>
> Yes, I'm getting some syzbot warnings as well now.
>
> I had however only planned to get this in linux-next, since that is what
> the syzbot mails were complaining about, but I see this got into -rc5...
>
>
> It's honestly just a warn on something that would fail anyway so I'd
> rather let it live in -next first, I don't get why syzbot is so verbose
> about this - it sent a mail when it found a c repro and one more once it
> bisected the commit yesterday but it should not be sending more?
Yes, I agree that this is just a warning on existing behavior. But then
again these constant syzbot reports are pretty annoying..
> (likewise it should pick up the fix tag even if it only gets in -next,
> or would it keep being noisy unless this gets merged to mainline?)
>
>
> FWIW this is along with the 5 other patches I have queued for 5.9
> waiting for my tests as my infra is still down, I've stopped trying to
> make promises, but I could push at least just this one to -next if that
> really helps.
> Sorry for that, things should be smoother once I've taken the time to
> put things back in place.
No need to be sorry, just through it might be worth to ping you.
Thanks for all your help!
next prev parent reply other threads:[~2020-07-15 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 8:57 [PATCH] net/9p: validate fds in p9_fd_open Christoph Hellwig
2020-07-10 11:12 ` Dominique Martinet
2020-07-10 22:56 ` Doug Nazar
2020-07-11 10:49 ` Dominique Martinet
2020-07-13 7:38 ` Christoph Hellwig
2020-07-15 7:37 ` Christoph Hellwig
2020-07-15 13:47 ` Dominique Martinet
2020-07-15 18:19 ` Christoph Hellwig [this message]
2020-07-15 21:24 ` David Miller
2020-07-16 7:58 ` Dominique Martinet
2020-07-16 20:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715181949.GA31172@lst.de \
--to=hch@lst.de \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=nazard@nazar.ca \
--cc=netdev@vger.kernel.org \
--cc=syzbot+e6f77e16ff68b2434a2c@syzkaller.appspotmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).