netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Priyaranjan Jha <priyarjha@google.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Priyaranjan Jha <priyarjha@google.com>
Subject: [PATCH net-next 0/2] tcp: improve handling of DSACK covering multiple segments
Date: Thu, 16 Jul 2020 12:12:33 -0700	[thread overview]
Message-ID: <20200716191235.1556723-1-priyarjha@google.com> (raw)

Currently, while processing DSACK, we assume DSACK covers only one
segment. This leads to significant underestimation of no. of duplicate
segments with LRO/GRO. Also, the existing SNMP counters, TCPDSACKRecv
and TCPDSACKOfoRecv, make similar assumption for DSACK, which makes them
unusable for estimating spurious retransmit rates.

This patch series fixes the segment accounting with DSACK, by estimating
number of duplicate segments based on: (DSACKed sequence range) / MSS.
It also introduces a new SNMP counter, TCPDSACKRecvSegs, which tracks
the estimated number of duplicate segments.

Priyaranjan Jha (2):
  tcp: fix segment accounting when DSACK range covers multiple segments
  tcp: add SNMP counter for no. of duplicate segments reported by DSACK

 include/uapi/linux/snmp.h |  1 +
 net/ipv4/proc.c           |  1 +
 net/ipv4/tcp_input.c      | 81 ++++++++++++++++++++++-----------------
 3 files changed, 47 insertions(+), 36 deletions(-)

-- 
2.27.0.389.gc38d7665816-goog


             reply	other threads:[~2020-07-16 19:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 19:12 Priyaranjan Jha [this message]
2020-07-16 19:12 ` [PATCH net-next 1/2] tcp: fix segment accounting when DSACK range covers multiple segments Priyaranjan Jha
2020-07-16 19:12 ` [PATCH net-next 2/2] tcp: add SNMP counter for no. of duplicate segments reported by DSACK Priyaranjan Jha
2020-07-17 19:54 ` [PATCH net-next 0/2] tcp: improve handling of DSACK covering multiple segments David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716191235.1556723-1-priyarjha@google.com \
    --to=priyarjha@google.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).