From: David Miller <davem@davemloft.net>
To: kgraul@linux.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
heiko.carstens@de.ibm.com, raspl@linux.ibm.com,
ubraun@linux.ibm.com
Subject: Re: [PATCH net 04/10] net/smc: protect smc ib device initialization
Date: Fri, 17 Jul 2020 12:30:27 -0700 (PDT) [thread overview]
Message-ID: <20200717.123027.1640292958732505858.davem@davemloft.net> (raw)
In-Reply-To: <20200716153746.77303-5-kgraul@linux.ibm.com>
From: Karsten Graul <kgraul@linux.ibm.com>
Date: Thu, 16 Jul 2020 17:37:40 +0200
> Fix that by protecting the critical code using a mutex.
...
> @@ -52,6 +52,7 @@ struct smc_ib_device { /* ib-device infos for smc */
> DECLARE_BITMAP(ports_going_away, SMC_MAX_PORTS);
> atomic_t lnk_cnt; /* number of links on ibdev */
> wait_queue_head_t lnks_deleted; /* wait 4 removal of all links*/
> + struct mutex mutex; /* protects smc ib device */
> };
So which is it? Does the mutex protect the entire contents of the
smc ib device struct, as stated in the comment? Or does it only
synchronize object creation?
One of them is obviously wrong, so please correct that.
next prev parent reply other threads:[~2020-07-17 19:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 15:37 [PATCH net 00/10] net/smc: fixes 2020-07-16 Karsten Graul
2020-07-16 15:37 ` [PATCH net 01/10] net/smc: handle unexpected response types for confirm link Karsten Graul
2020-07-16 15:37 ` [PATCH net 02/10] net/smc: clear link during SMC client link down processing Karsten Graul
2020-07-16 15:37 ` [PATCH net 03/10] net/smc: fix link lookup for new rdma connections Karsten Graul
2020-07-16 15:37 ` [PATCH net 04/10] net/smc: protect smc ib device initialization Karsten Graul
2020-07-17 19:30 ` David Miller [this message]
2020-07-16 15:37 ` [PATCH net 05/10] net/smc: drop out-of-flow llc response messages Karsten Graul
2020-07-16 15:37 ` [PATCH net 06/10] net/smc: move add link processing for new device into llc layer Karsten Graul
2020-07-16 15:37 ` [PATCH net 07/10] net/smc: fix handling of delete link requests Karsten Graul
2020-07-16 15:37 ` [PATCH net 08/10] net/smc: do not call dma sync for unmapped memory Karsten Graul
2020-07-16 15:37 ` [PATCH net 09/10] net/smc: remove freed buffer from list Karsten Graul
2020-07-16 15:37 ` [PATCH net 10/10] net/smc: fix restoring of fallback changes Karsten Graul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717.123027.1640292958732505858.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).