From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE5AC433E1 for ; Sat, 18 Jul 2020 01:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F6E72073E for ; Sat, 18 Jul 2020 01:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgGRBlr (ORCPT ); Fri, 17 Jul 2020 21:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgGRBlr (ORCPT ); Fri, 17 Jul 2020 21:41:47 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15565C0619D2 for ; Fri, 17 Jul 2020 18:41:47 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8987111E45914; Fri, 17 Jul 2020 18:41:46 -0700 (PDT) Date: Fri, 17 Jul 2020 18:41:45 -0700 (PDT) Message-Id: <20200717.184145.1710848863414831357.davem@davemloft.net> To: liujian56@huawei.com Cc: madalin.bucur@nxp.com, kuba@kernel.org, laurentiu.tudor@nxp.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] dpaa_eth: Fix one possible memleak in dpaa_eth_probe From: David Miller In-Reply-To: <20200717090528.19683-1-liujian56@huawei.com> References: <20200717090528.19683-1-liujian56@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Jul 2020 18:41:46 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Liu Jian Date: Fri, 17 Jul 2020 17:05:28 +0800 > When dma_coerce_mask_and_coherent() fails, the alloced netdev need to be freed. > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") > Signed-off-by: Liu Jian This is a bug fix introduced in v5.5, therefore it should be targetting 'net' instead of 'net-next'.