From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51774C433E3 for ; Sat, 18 Jul 2020 01:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 398342070E for ; Sat, 18 Jul 2020 01:56:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbgGRB4M (ORCPT ); Fri, 17 Jul 2020 21:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726665AbgGRB4M (ORCPT ); Fri, 17 Jul 2020 21:56:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22CB7C0619D2; Fri, 17 Jul 2020 18:56:12 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AAEFE11E4590D; Fri, 17 Jul 2020 18:56:11 -0700 (PDT) Date: Fri, 17 Jul 2020 18:56:11 -0700 (PDT) Message-Id: <20200717.185611.1278374862685166021.davem@davemloft.net> To: m-karicheri2@ti.com Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, nsekhar@ti.com, grygorii.strashko@ti.com, vinicius.gomes@intel.com Subject: Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP From: David Miller In-Reply-To: <20200717151511.329-2-m-karicheri2@ti.com> References: <20200717151511.329-1-m-karicheri2@ti.com> <20200717151511.329-2-m-karicheri2@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Jul 2020 18:56:12 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:05 -0400 > @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev, > struct netlink_ext_ack *extack) > { > struct net_device *link[2]; > - unsigned char multicast_spec, hsr_version; > + unsigned char multicast_spec; > + enum hsr_version proto_version; > + u8 proto = HSR_PROTOCOL_HSR; Please use reverse christmas tree ordering for local variables. Thank you.