From: Florian Westphal <fw@strlen.de>
To: wenxu@ucloud.cn
Cc: fw@strlen.de, xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag
Date: Sat, 18 Jul 2020 14:30:06 +0200 [thread overview]
Message-ID: <20200718123006.GW32005@breakpoint.cc> (raw)
In-Reply-To: <1595072073-6268-1-git-send-email-wenxu@ucloud.cn>
wenxu@ucloud.cn <wenxu@ucloud.cn> wrote:
> From: wenxu <wenxu@ucloud.cn>
>
> The fragment packets do defrag in tcf_ct_handle_fragments
> will clear the skb->cb which make the qdisc_skb_cb clear
> too. So the qdsic_skb_cb should be store before defrag and
> restore after that.
> It also update the pkt_len after all the
> fragments finish the defrag to one packet and make the
> following actions counter correct.
>
> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
> Signed-off-by: wenxu <wenxu@ucloud.cn>
Looks ok to me. One question:
> @@ -1014,6 +1017,7 @@ static int tcf_ct_act(struct sk_buff *skb, const struct tc_action *a,
>
> out:
> tcf_action_update_bstats(&c->common, skb);
> + qdisc_skb_cb(skb)->pkt_len = skb->len;
> return retval;
This appears to be unconditional, I would have expected that
this only done for reassembled skbs?
Otherwise we will lose the value calculated by core via
qdisc_calculate_pkt_len().
next prev parent reply other threads:[~2020-07-18 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 11:34 [PATCH net] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag wenxu
2020-07-18 12:30 ` Florian Westphal [this message]
2020-07-19 1:31 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718123006.GW32005@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).