From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FBAC433DF for ; Sat, 18 Jul 2020 15:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFE1F20657 for ; Sat, 18 Jul 2020 15:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbgGRPWr (ORCPT ); Sat, 18 Jul 2020 11:22:47 -0400 Received: from lists.nic.cz ([217.31.204.67]:52938 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbgGRPWq (ORCPT ); Sat, 18 Jul 2020 11:22:46 -0400 Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id E64E9140527; Sat, 18 Jul 2020 17:22:44 +0200 (CEST) Date: Sat, 18 Jul 2020 17:22:44 +0200 From: Marek Behun To: Andrew Lunn Cc: Chris Healy , netdev Subject: Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c Message-ID: <20200718172244.59576938@nic.cz> In-Reply-To: <20200718150514.GC1375379@lunn.ch> References: <20200718164239.40ded692@nic.cz> <20200718150514.GC1375379@lunn.ch> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 18 Jul 2020 17:05:14 +0200 Andrew Lunn wrote: > > If the traces were broken between the fiber module and the SERDES, I > > should not see these counters incrementing. > > Plus it is reproducible on multiple boards, of different designs. > > This is somehow specific to the 6390X ports 9 and 10. > > Andrew Hmm. What about the errata setup? It says: /* The 6390 copper ports have an errata which require poking magic * values into undocumented hidden registers and then performing a * software reset. */ But then the port_hidden_write function is called for every port in the function mv88e6390_setup_errata, not just for copper ports. Maybe Chris should try to not write this hidden register for SerDes ports. Marek