* [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration
@ 2020-07-19 11:00 Russell King
2020-07-19 15:27 ` Andrew Lunn
2020-07-20 1:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2020-07-19 11:00 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Martin Rowe
Cc: David S. Miller, devicetree, Gregory Clement, Jakub Kicinski,
Jason Cooper, linux-arm-kernel, netdev, Rob Herring,
Sebastian Hesselbarth, Vivien Didelot
The commit below caused a regression for clearfog-gt-8k, where the link
between the switch and the host does not come up.
Investigation revealed two issues:
- MV88E6xxx DSA no longer allows an in-band link to come up as the link
is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
in-band AN link establishment" addresses this.
- The dts configured dissimilar link modes at each end of the host to
switch link; the host was configured using a fixed link (so has no
in-band status) and the switch was configured to expect in-band
status.
With both issues fixed, the regression is resolved.
Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index c8243da71041..eb01cc96ba7a 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -454,10 +454,7 @@
status = "okay";
phy-mode = "2500base-x";
phys = <&cp1_comphy5 2>;
- fixed-link {
- speed = <2500>;
- full-duplex;
- };
+ managed = "in-band-status";
};
&cp1_spi1 {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration
2020-07-19 11:00 [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration Russell King
@ 2020-07-19 15:27 ` Andrew Lunn
2020-07-20 1:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-07-19 15:27 UTC (permalink / raw)
To: Russell King
Cc: Florian Fainelli, Heiner Kallweit, Martin Rowe, David S. Miller,
devicetree, Gregory Clement, Jakub Kicinski, Jason Cooper,
linux-arm-kernel, netdev, Rob Herring, Sebastian Hesselbarth,
Vivien Didelot
On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote:
> The commit below caused a regression for clearfog-gt-8k, where the link
> between the switch and the host does not come up.
>
> Investigation revealed two issues:
> - MV88E6xxx DSA no longer allows an in-band link to come up as the link
> is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
> in-band AN link establishment" addresses this.
>
> - The dts configured dissimilar link modes at each end of the host to
> switch link; the host was configured using a fixed link (so has no
> in-band status) and the switch was configured to expect in-band
> status.
>
> With both issues fixed, the regression is resolved.
>
> Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
> Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration
2020-07-19 11:00 [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration Russell King
2020-07-19 15:27 ` Andrew Lunn
@ 2020-07-20 1:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-20 1:11 UTC (permalink / raw)
To: rmk+kernel
Cc: andrew, f.fainelli, hkallweit1, martin.p.rowe, devicetree,
gregory.clement, kuba, jason, linux-arm-kernel, netdev, robh+dt,
sebastian.hesselbarth, vivien.didelot
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Sun, 19 Jul 2020 12:00:40 +0100
> The commit below caused a regression for clearfog-gt-8k, where the link
> between the switch and the host does not come up.
>
> Investigation revealed two issues:
> - MV88E6xxx DSA no longer allows an in-band link to come up as the link
> is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
> in-band AN link establishment" addresses this.
>
> - The dts configured dissimilar link modes at each end of the host to
> switch link; the host was configured using a fixed link (so has no
> in-band status) and the switch was configured to expect in-band
> status.
>
> With both issues fixed, the regression is resolved.
>
> Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
> Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-19 11:00 [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration Russell King
2020-07-19 15:27 ` Andrew Lunn
2020-07-20 1:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).