netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: briana.oursler@gmail.com
Cc: jhs@mojatatu.com, mrv@mojatatu.com, shuah@kernel.org,
	sbrivio@redhat.com, dcaratti@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tc-testing: Add tdc to kselftests
Date: Mon, 20 Jul 2020 18:30:10 -0700 (PDT)	[thread overview]
Message-ID: <20200720.183010.1627184066290103703.davem@davemloft.net> (raw)
In-Reply-To: <20200717215439.51672-1-briana.oursler@gmail.com>

From: Briana Oursler <briana.oursler@gmail.com>
Date: Fri, 17 Jul 2020 14:54:39 -0700

> Add tdc to existing kselftest infrastructure so that it can be run with
> existing kselftests. TDC now generates objects in objdir/kselftest
> without cluttering main objdir, leaves source directory clean, and
> installs correctly in kselftest_install, properly adding itself to
> run_kselftest.sh script.
> 
> Add tc-testing as a target of selftests/Makefile. Create tdc.sh to run
> tdc.py targets with correct arguments. To support single target from
> selftest/Makefile, combine tc-testing/bpf/Makefile and
> tc-testing/Makefile. Move action.c up a directory to tc-testing/.
> 
> Tested with:
>  make O=/tmp/{objdir} TARGETS="tc-testing" kselftest
>  cd /tmp/{objdir}
>  cd kselftest
>  cd tc-testing
>  ./tdc.sh
> 
>  make -C tools/testing/selftests/ TARGETS=tc-testing run_tests
> 
>  make TARGETS="tc-testing" kselftest
>  cd tools/testing/selftests
>  ./kselftest_install.sh /tmp/exampledir
>  My VM doesn't run all the kselftests so I commented out all except my
>  target and net/pmtu.sh then:
>  cd /tmp/exampledir && ./run_kselftest.sh
> 
> Co-developed-by: Davide Caratti <dcaratti@redhat.com>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> Signed-off-by: Briana Oursler <briana.oursler@gmail.com>

Applied, but:

> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +./tdc.py -c actions --nobuildebpf
> +./tdc.py -c qdisc
> +

I had to remove this trailing newline.

      reply	other threads:[~2020-07-21  1:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 21:54 [PATCH net-next] tc-testing: Add tdc to kselftests Briana Oursler
2020-07-21  1:30 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720.183010.1627184066290103703.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=briana.oursler@gmail.com \
    --cc=dcaratti@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).