From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4854DC433E2 for ; Tue, 21 Jul 2020 01:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F7CF20714 for ; Tue, 21 Jul 2020 01:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgGUBbO (ORCPT ); Mon, 20 Jul 2020 21:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgGUBbO (ORCPT ); Mon, 20 Jul 2020 21:31:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B408C061794; Mon, 20 Jul 2020 18:31:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E513011FFCC36; Mon, 20 Jul 2020 18:14:28 -0700 (PDT) Date: Mon, 20 Jul 2020 18:31:13 -0700 (PDT) Message-Id: <20200720.183113.2100585349998522874.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: vishal@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu Subject: Re: [PATCH] cxgb4: add missing release on skb in uld_send() From: David Miller In-Reply-To: <20200718051845.10218-1-navid.emamdoost@gmail.com> References: <20200718051845.10218-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 18:14:29 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Navid Emamdoost Date: Sat, 18 Jul 2020 00:18:43 -0500 > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c > index 32a45dc51ed7..d8c37fd4b808 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c > @@ -2938,6 +2938,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb, > txq_info = adap->sge.uld_txq_info[tx_uld_type]; > if (unlikely(!txq_info)) { > WARN_ON(true); > + consume_skb(skb); > return NET_XMIT_DROP; > } > This is a packet drop so kfree_skb() is more appropriate here.