From: David Miller <davem@davemloft.net>
To: christophe.jaillet@wanadoo.fr
Cc: isdn@linux-pingi.de, sergey.senozhatsky@gmail.com,
wangkefeng.wang@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mISDN: switch from 'pci_' to 'dma_' API
Date: Mon, 20 Jul 2020 18:32:33 -0700 (PDT) [thread overview]
Message-ID: <20200720.183233.1523852489153157390.davem@davemloft.net> (raw)
In-Reply-To: <20200718103033.352247-1-christophe.jaillet@wanadoo.fr>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sat, 18 Jul 2020 12:30:33 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> When memory is allocated in 'setup_hw()' (hfcpci.c) GFP_KERNEL can be used
> because it is called from the probe function and no lock is taken.
> The call chain is:
> hfc_probe()
> --> setup_card()
> --> setup_hw()
>
> When memory is allocated in 'inittiger()' (netjet.c) GFP_ATOMIC must be
> used because a spin_lock is taken by the caller (i.e. 'nj_init_card()')
> This is also consistent with the other allocations done in the function.
...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thanks.
prev parent reply other threads:[~2020-07-21 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 10:30 [PATCH] mISDN: switch from 'pci_' to 'dma_' API Christophe JAILLET
2020-07-21 1:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720.183233.1523852489153157390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).