From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A75C433E0 for ; Tue, 21 Jul 2020 03:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68E56206E3 for ; Tue, 21 Jul 2020 03:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbgGUDNV (ORCPT ); Mon, 20 Jul 2020 23:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbgGUDNV (ORCPT ); Mon, 20 Jul 2020 23:13:21 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD17C061794 for ; Mon, 20 Jul 2020 20:13:21 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 84EBB1260D090; Mon, 20 Jul 2020 19:56:34 -0700 (PDT) Date: Mon, 20 Jul 2020 20:12:26 -0700 (PDT) Message-Id: <20200720.201226.912664403829372463.davem@davemloft.net> To: tung.q.nguyen@dektech.com.au Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: Re: [tipc-discussion] [net v1 1/1] tipc: allow to build NACK message in link timeout function From: David Miller In-Reply-To: <20200721015705.2333-1-tung.q.nguyen@dektech.com.au> References: <20200721015705.2333-1-tung.q.nguyen@dektech.com.au> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 19:56:34 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tung Nguyen Date: Tue, 21 Jul 2020 08:57:05 +0700 > Commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages") > eliminated sending of the 'gap' indicator in regular ACK messages and > only allowed to build NACK message with enabled probe/probe_reply. > However, necessary correction for building NACK message was missed > in tipc_link_timeout() function. This leads to significant delay and > link reset (due to retransmission failure) in lossy environment. > > This commit fixes it by setting the 'probe' flag to 'true' when > the receive deferred queue is not empty. As a result, NACK message > will be built to send back to another peer. > > Fixes: commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages") "commit" doesn't belong here, I removed it when I applied your patch. > Acked-by: Jon Maloy > Signed-off-by: Tung Nguyen Applied and queued up for -stable, thanks.