From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13CBC433E1 for ; Mon, 20 Jul 2020 06:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B754B21775 for ; Mon, 20 Jul 2020 06:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgGTG3H (ORCPT ); Mon, 20 Jul 2020 02:29:07 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:41371 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgGTG3G (ORCPT ); Mon, 20 Jul 2020 02:29:06 -0400 Received: from localhost (bharat.asicdesigners.com [10.193.177.155] (may be forged)) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 06K6SciR031082; Sun, 19 Jul 2020 23:28:52 -0700 Date: Mon, 20 Jul 2020 11:58:37 +0530 From: Vishal Kulkarni To: Andrew Lunn Cc: netdev@vger.kernel.org, davem@davemloft.net, nirranjan@chelsio.com Subject: Re: [PATCH net-next 0/4] cxgb4: add ethtool self_test support Message-ID: <20200720062837.GA22415@chelsio.com> References: <20200717134759.8268-1-vishal@chelsio.com> <20200717180251.GC1339445@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717180251.GC1339445@lunn.ch> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Friday, July 07/17/20, 2020 at 20:02:51 +0200, Andrew Lunn wrote: > On Fri, Jul 17, 2020 at 07:17:55PM +0530, Vishal Kulkarni wrote: > > This series of patches add support for below tests. > > 1. Adapter status test > > 2. Link test > > 3. Link speed test > > 4. Loopback test > > Hi Vishal > > The loopback test is pretty usual for an ethtool self test. But the > first 3 are rather odd. They don't really seem to be self tests. What > reason do you have for adding these? Are you trying to debug a > specific problem? > > Andrew Hi Andrew, Our requirement is to add a list of self tests that can summarize if the adapter is functioning properly in a single command during system init. The above tests are the most common ones run by our on-field diagnostics team. Besides, these tests seem to be the most common among other drivers as well. Hence we have added 1. Adapter status test: Tests whether the adapter is alive or crashed 2. Link test: Adapter PHY is up or not. 3. Link speed test: Adapter has negotiated link speed correctly or not. -Vishal