From: David Miller <davem@davemloft.net>
To: linux@armlinux.org.uk
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
ioana.ciornei@nxp.com, alexandru.marginean@nxp.com,
claudiu.manoil@nxp.com, kuba@kernel.org, michael@walle.cc,
netdev@vger.kernel.org, olteanv@gmail.com,
vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next 00/14] Phylink PCS updates
Date: Tue, 21 Jul 2020 15:47:29 -0700 (PDT) [thread overview]
Message-ID: <20200721.154729.1573922846524745029.davem@davemloft.net> (raw)
In-Reply-To: <20200721110152.GY1551@shell.armlinux.org.uk>
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Tue, 21 Jul 2020 12:01:52 +0100
> This series updates the rudimentary phylink PCS support with the
> results of the last four months of development of that. Phylink
> PCS support was initially added back at the end of March, when it
> became clear that the current approach of treating everything at
> the MAC end as being part of the MAC was inadequate.
>
> However, this rudimentary implementation was fine initially for
> mvneta and similar, but in practice had a fair number of issues,
> particularly when ethtool interfaces were used to change various
> link properties.
>
> It became apparent that relying on the phylink_config structure for
> the PCS was also bad when it became clear that the same PCS was used
> in DSA drivers as well as in NXPs other offerings, and there was a
> desire to re-use that code.
>
> It also became apparent that splitting the "configuration" step on
> an interface mode configuration between the MAC and PCS using just
> mac_config() and pcs_config() methods was not sufficient for some
> setups, as the MAC needed to be "taken down" prior to making changes,
> and once all settings were complete, the MAC could only then be
> resumed.
>
> This series addresses these points, progressing PCS support, and
> has been developed with mvneta and DPAA2 setups, with work on both
> those drivers to prove this approach. It has been rigorously tested
> with mvneta, as that provides the most flexibility for testing the
> various code paths.
...
Series applied, thank you.
prev parent reply other threads:[~2020-07-21 22:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 11:01 [PATCH net-next 00/14] Phylink PCS updates Russell King - ARM Linux admin
2020-07-21 11:03 ` [PATCH net-next 01/14] net: phylink: update ethtool reporting for fixed-link modes Russell King
2020-07-21 11:03 ` [PATCH net-next 02/14] net: phylink: rejig link state tracking Russell King
2020-07-21 11:03 ` [PATCH net-next 03/14] net: phylink: rearrange resolve mac_config() call Russell King
2020-07-21 11:04 ` [PATCH net-next 04/14] net: phylink: ensure link is down when changing interface Russell King
2020-07-21 11:04 ` [PATCH net-next 05/14] net: phylink: update PCS when changing interface during resolution Russell King
2020-07-21 11:04 ` [PATCH net-next 06/14] net: phylink: avoid mac_config calls Russell King
2020-07-21 11:04 ` [PATCH net-next 07/14] net: phylink: simplify ksettings_set() implementation Russell King
2020-07-21 11:04 ` [PATCH net-next 08/14] net: phylink: simplify phy case for ksettings_set method Russell King
2020-07-21 11:04 ` [PATCH net-next 09/14] net: phylink: use config.an_enabled in " Russell King
2020-07-21 11:04 ` [PATCH net-next 10/14] net: phylink: simplify fixed-link case for " Russell King
2020-07-21 11:04 ` [PATCH net-next 11/14] net: phylink: in-band pause mode advertisement update for PCS Russell King
2020-07-21 11:04 ` [PATCH net-next 12/14] net: phylink: re-implement interface configuration with PCS Russell King
2020-07-21 11:04 ` [PATCH net-next 13/14] net: phylink: add struct phylink_pcs Russell King
2020-07-21 11:04 ` [PATCH net-next 14/14] net: phylink: add interface to configure clause 22 PCS PHY Russell King
2020-07-21 22:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721.154729.1573922846524745029.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).