From: David Miller <davem@davemloft.net>
To: geffrey.guo@huawei.com
Cc: kuba@kernel.org, maheshb@google.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipvlan: add the check of ip header checksum
Date: Tue, 21 Jul 2020 15:55:44 -0700 (PDT) [thread overview]
Message-ID: <20200721.155544.425274580821501846.davem@davemloft.net> (raw)
In-Reply-To: <1595336962-98677-1-git-send-email-geffrey.guo@huawei.com>
From: guodeqing <geffrey.guo@huawei.com>
Date: Tue, 21 Jul 2020 21:09:22 +0800
> The ip header checksum can be error in the following steps.
...
> $ ip netns exec ns1 tc qdisc add dev ip1 root netem corrupt 50%
This is not valid.
The kernel internally already validated the ipv4 header checksum
before forwarding or sending it on egress to the ipvlan device.
The driver can legitimately depend upon this validation.
Besides, as Cong pointed out, so much other code in the ipvlan
driver has read various ipv4 header members such as the addresses
necessary to perform lookups.
prev parent reply other threads:[~2020-07-21 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 13:09 [PATCH] ipvlan: add the check of ip header checksum guodeqing
2020-07-21 19:39 ` Cong Wang
2020-07-22 9:22 ` 答复: " Guodeqing (A)
2020-07-21 22:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721.155544.425274580821501846.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geffrey.guo@huawei.com \
--cc=kuba@kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).