From: David Miller <davem@davemloft.net>
To: ap420073@gmail.com
Cc: kuba@kernel.org, netdev@vger.kernel.org, jiri@mellanox.com
Subject: Re: [PATCH net v2] netdevsim: fix unbalaced locking in nsim_create()
Date: Tue, 21 Jul 2020 16:09:56 -0700 (PDT) [thread overview]
Message-ID: <20200721.160956.1015616148171478130.davem@davemloft.net> (raw)
In-Reply-To: <20200721145150.25964-1-ap420073@gmail.com>
From: Taehee Yoo <ap420073@gmail.com>
Date: Tue, 21 Jul 2020 14:51:50 +0000
> In the nsim_create(), rtnl_lock() is called before nsim_bpf_init().
> If nsim_bpf_init() is failed, rtnl_unlock() should be called,
> but it isn't called.
> So, unbalanced locking would occur.
>
> Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2020-07-21 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:51 [PATCH net v2] netdevsim: fix unbalaced locking in nsim_create() Taehee Yoo
2020-07-21 19:27 ` Jakub Kicinski
2020-07-21 23:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721.160956.1015616148171478130.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ap420073@gmail.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).