From: David Miller <davem@davemloft.net>
To: wanghai38@huawei.com
Cc: hayashi.kunihiko@socionext.com, kuba@kernel.org,
p.zabel@pengutronix.de, yamada.masahiro@socionext.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init
Date: Tue, 21 Jul 2020 18:32:07 -0700 (PDT) [thread overview]
Message-ID: <20200721.183207.2040938284749662736.davem@davemloft.net> (raw)
In-Reply-To: <20200717025049.43027-1-wanghai38@huawei.com>
From: Wang Hai <wanghai38@huawei.com>
Date: Fri, 17 Jul 2020 10:50:49 +0800
> When regmap_update_bits failed in ave_init(), calls of the functions
> reset_control_assert() and clk_disable_unprepare() were missed.
> Add goto out_reset_assert to do this.
>
> Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of system controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Applied.
prev parent reply other threads:[~2020-07-22 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 2:50 [PATCH] net: ethernet: ave: Fix error returns in ave_init Wang Hai
2020-07-17 4:16 ` Kunihiko Hayashi
2020-07-22 1:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721.183207.2040938284749662736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayashi.kunihiko@socionext.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wanghai38@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).