* [PATCH net-next] mptcp: zero token hash at creation time.
@ 2020-07-22 15:20 Paolo Abeni
2020-07-23 0:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2020-07-22 15:20 UTC (permalink / raw)
To: netdev; +Cc: mptcp, David S. Miller
Otherwise the 'chain_len' filed will carry random values,
some token creation calls will fail due to excessive chain
length, causing unexpected fallback to TCP.
Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
net/mptcp/token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index b25b390dbbff..97cfc45bcc4f 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -368,7 +368,7 @@ void __init mptcp_token_init(void)
sizeof(struct token_bucket),
0,
20,/* one slot per 1MB of memory */
- 0,
+ HASH_ZERO,
NULL,
&token_mask,
0,
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mptcp: zero token hash at creation time.
2020-07-22 15:20 [PATCH net-next] mptcp: zero token hash at creation time Paolo Abeni
@ 2020-07-23 0:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-23 0:57 UTC (permalink / raw)
To: pabeni; +Cc: netdev, mptcp
From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 22 Jul 2020 17:20:50 +0200
> Otherwise the 'chain_len' filed will carry random values,
> some token creation calls will fail due to excessive chain
> length, causing unexpected fallback to TCP.
>
> Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> Tested-by: Christoph Paasch <cpaasch@apple.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks Paolo.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-23 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-22 15:20 [PATCH net-next] mptcp: zero token hash at creation time Paolo Abeni
2020-07-23 0:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).