From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: jreuter@yaina.de, yepeilin.cs@gmail.com, ralf@linux-mips.org,
kuba@kernel.org, linux-hams@vger.kernel.org,
netdev@vger.kernel.org, gregkh@linuxfoundation.org,
syzkaller-bugs@googlegroups.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net] AX.25: Prevent integer overflows in connect and sendmsg
Date: Thu, 23 Jul 2020 12:10:37 -0700 (PDT) [thread overview]
Message-ID: <20200723.121037.1733642913138811577.davem@davemloft.net> (raw)
In-Reply-To: <20200723144957.GA293102@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 23 Jul 2020 17:49:57 +0300
> We recently added some bounds checking in ax25_connect() and
> ax25_sendmsg() and we so we removed the AX25_MAX_DIGIS checks because
> they were no longer required.
>
> Unfortunately, I believe they are required to prevent integer overflows
> so I have added them back.
>
> Fixes: 8885bb0621f0 ("AX.25: Prevent out-of-bounds read in ax25_sendmsg()")
> Fixes: 2f2a7ffad5c6 ("AX.25: Fix out-of-bounds read in ax25_connect()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
next prev parent reply other threads:[~2020-07-23 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 15:19 [Linux-kernel-mentees] [PATCH net] AX.25: Fix out-of-bounds read in ax25_connect() Peilin Ye
2020-07-23 0:57 ` David Miller
2020-07-23 14:49 ` [PATCH net] AX.25: Prevent integer overflows in connect and sendmsg Dan Carpenter
2020-07-23 19:10 ` David Miller [this message]
2020-07-23 15:15 ` [Linux-kernel-mentees] [PATCH net] AX.25: Fix out-of-bounds read in ax25_connect() Peilin Ye
2020-07-23 14:28 ` Dan Carpenter
2020-07-23 15:13 ` Peilin Ye
2020-07-23 15:50 ` Dan Carpenter
2020-07-23 16:43 ` Peilin Ye
2020-07-23 21:41 ` vk2tv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723.121037.1733642913138811577.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jreuter@yaina.de \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).