From: David Miller <davem@davemloft.net>
To: andrea.righi@canonical.com
Cc: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, kuba@kernel.org,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-netfront: fix potential deadlock in xennet_remove()
Date: Thu, 23 Jul 2020 14:57:22 -0700 (PDT) [thread overview]
Message-ID: <20200723.145722.752878326752101646.davem@davemloft.net> (raw)
In-Reply-To: <20200722065211.GA841369@xps-13>
From: Andrea Righi <andrea.righi@canonical.com>
Date: Wed, 22 Jul 2020 08:52:11 +0200
> +static int xennet_remove(struct xenbus_device *dev)
> +{
> + struct netfront_info *info = dev_get_drvdata(&dev->dev);
> +
> + dev_dbg(&dev->dev, "%s\n", dev->nodename);
These kinds of debugging messages provide zero context and are so much
less useful than simply using tracepoints which are more universally
available than printk debugging facilities.
Please remove all of the dev_dbg() calls from this patch.
next prev parent reply other threads:[~2020-07-23 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 6:52 [PATCH] xen-netfront: fix potential deadlock in xennet_remove() Andrea Righi
2020-07-23 21:57 ` David Miller [this message]
2020-07-24 6:30 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723.145722.752878326752101646.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrea.righi@canonical.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).