From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74321C433E4 for ; Thu, 23 Jul 2020 22:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B3422065F for ; Thu, 23 Jul 2020 22:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbgGWWUo (ORCPT ); Thu, 23 Jul 2020 18:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbgGWWUo (ORCPT ); Thu, 23 Jul 2020 18:20:44 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CD5EC0619D3 for ; Thu, 23 Jul 2020 15:20:44 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B635411E48C64; Thu, 23 Jul 2020 15:03:58 -0700 (PDT) Date: Thu, 23 Jul 2020 15:20:42 -0700 (PDT) Message-Id: <20200723.152042.2176694627732181944.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, syzbot+7ebc2e088af5e4c0c9fa@syzkaller.appspotmail.com, sd@queasysnail.net Subject: Re: [Patch net] geneve: fix an uninitialized value in geneve_changelink() From: David Miller In-Reply-To: <20200723015625.19255-1-xiyou.wangcong@gmail.com> References: <20200723015625.19255-1-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Jul 2020 15:03:58 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Wed, 22 Jul 2020 18:56:25 -0700 > geneve_nl2info() sets 'df' conditionally, so we have to > initialize it by copying the value from existing geneve > device in geneve_changelink(). > > Fixes: 56c09de347e4 ("geneve: allow changing DF behavior after creation") > Reported-by: syzbot+7ebc2e088af5e4c0c9fa@syzkaller.appspotmail.com > Cc: Sabrina Dubroca > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks Cong.