From: Richard Cochran <richardcochran@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/2] ptp: Add generic header parsing function
Date: Thu, 23 Jul 2020 10:08:42 -0700 [thread overview]
Message-ID: <20200723170842.GB2975@hoboy> (raw)
In-Reply-To: <20200723074946.14253-1-kurt@linutronix.de>
Kurt,
On Thu, Jul 23, 2020 at 09:49:44AM +0200, Kurt Kanzenbach wrote:
> in order to reduce code duplication in the ptp code of DSA drivers, move the
> header parsing function to ptp_classify. This way the Marvell and the hellcreek
> drivers can share the same implementation. And probably more drivers can benefit
> from it. Implemented as discussed [1] [2].
This looks good. I made a list of drivers that can possibily use this helper.
Finding symbol: PTP_CLASS_PMASK
*** drivers/net/dsa/mv88e6xxx/hwtstamp.c:
parse_ptp_header[223] switch (type & PTP_CLASS_PMASK) {
*** drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c:
mlxsw_sp_ptp_parse[335] switch (ptp_class & PTP_CLASS_PMASK) {
*** drivers/net/ethernet/ti/am65-cpts.c:
am65_skb_get_mtype_seqid[761] switch (ptp_class & PTP_CLASS_PMASK) {
*** drivers/net/ethernet/ti/cpts.c:
cpts_skb_get_mtype_seqid[459] switch (ptp_class & PTP_CLASS_PMASK) {
*** drivers/net/phy/dp83640.c:
match[815] switch (type & PTP_CLASS_PMASK) {
is_sync[990] switch (type & PTP_CLASS_PMASK) {
*** drivers/ptp/ptp_ines.c:
ines_match[457] switch (ptp_class & PTP_CLASS_PMASK) {
is_sync_pdelay_resp[703] switch (type & PTP_CLASS_PMASK) {
> @DSA maintainers: Please, have a look the Marvell code. I don't have hardware to
> test it. I've tested this series only on the Hirschmann switch.
I'll test the marvell switch with your change and let you know...
Thanks,
Richard
next prev parent reply other threads:[~2020-07-23 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:49 [PATCH v1 0/2] ptp: Add generic header parsing function Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 1/2] ptp: Add generic ptp v2 " Kurt Kanzenbach
2020-07-23 10:54 ` Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp " Kurt Kanzenbach
2020-07-23 17:11 ` Richard Cochran
2020-07-24 6:07 ` Kurt Kanzenbach
2020-07-23 17:08 ` Richard Cochran [this message]
2020-07-24 6:25 ` [PATCH v1 0/2] ptp: Add generic " Kurt Kanzenbach
2020-07-24 16:03 ` Richard Cochran
2020-07-25 7:04 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723170842.GB2975@hoboy \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).