From: Richard Cochran <richardcochran@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp header parsing function
Date: Thu, 23 Jul 2020 10:11:50 -0700 [thread overview]
Message-ID: <20200723171150.GC2975@hoboy> (raw)
In-Reply-To: <20200723074946.14253-3-kurt@linutronix.de>
On Thu, Jul 23, 2020 at 09:49:46AM +0200, Kurt Kanzenbach wrote:
> @@ -26,6 +26,7 @@ config NET_DSA_MV88E6XXX_PTP
> depends on NET_DSA_MV88E6XXX_GLOBAL2
> depends on PTP_1588_CLOCK
> imply NETWORK_PHY_TIMESTAMPING
> + select NET_PTP_CLASSIFY
Hm, PTP_1588_CLOCK already selects NET_PTP_CLASSIFY,
config PTP_1588_CLOCK
tristate "PTP clock support"
depends on NET && POSIX_TIMERS
select PPS
select NET_PTP_CLASSIFY
and so I expect that the 'select' in NET_DSA_MV88E6XXX_PTP isn't
needed. What am I missing?
Thanks,
Richard
next prev parent reply other threads:[~2020-07-23 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:49 [PATCH v1 0/2] ptp: Add generic header parsing function Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 1/2] ptp: Add generic ptp v2 " Kurt Kanzenbach
2020-07-23 10:54 ` Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp " Kurt Kanzenbach
2020-07-23 17:11 ` Richard Cochran [this message]
2020-07-24 6:07 ` Kurt Kanzenbach
2020-07-23 17:08 ` [PATCH v1 0/2] ptp: Add generic " Richard Cochran
2020-07-24 6:25 ` Kurt Kanzenbach
2020-07-24 16:03 ` Richard Cochran
2020-07-25 7:04 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723171150.GC2975@hoboy \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).