From: Stephen Hemminger <stephen@networkplumber.org>
To: nikolay@cumulusnetworks.com
Cc: George Shuklin <amarao@servers.com>,
netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [RFT iproute2] iplink_bridge: scale all time values by USER_HZ
Date: Fri, 24 Jul 2020 12:05:13 -0700 [thread overview]
Message-ID: <20200724120513.13d4b3b1@hermes.lan> (raw)
In-Reply-To: <F074B3B5-1B07-490F-87B8-887E2EFB32F3@cumulusnetworks.com>
On Fri, 24 Jul 2020 19:24:35 +0300
nikolay@cumulusnetworks.com wrote:
> On 24 July 2020 19:15:17 EEST, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> >The bridge portion of ip command was not scaling so the
> >values were off.
> >
> >The netlink API's for setting and reading timers all conform
> >to the kernel standard of scaling the values by USER_HZ (100).
> >
> >Fixes: 28d84b429e4e ("add bridge master device support")
> >Fixes: 7f3d55922645 ("iplink: bridge: add support for
> >IFLA_BR_MCAST_MEMBERSHIP_INTVL")
> >Fixes: 10082a253fb2 ("iplink: bridge: add support for
> >IFLA_BR_MCAST_LAST_MEMBER_INTVL")
> >Fixes: 1f2244b851dd ("iplink: bridge: add support for
> >IFLA_BR_MCAST_QUERIER_INTVL")
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >---
>
> While I agree this should have been done from the start, it's too late to change.
> We'll break everyone using these commands.
> We have been discussing to add _ms version of all these which do the proper scaling. I'd prefer that, it's least disruptive
> to users.
>
> Every user of the old commands scales the values by now.
So bridge is inconsistent with all other api's in iproute2!
And the bridge option in ip link is scaled differently than the bridge-utils or sysfs.
Maybe an environment variable?
Or add new fixed syntax option and don't show the old syntax?
next prev parent reply other threads:[~2020-07-24 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 12:45 Bug in iproute2 man page (or in iproute itself) George Shuklin
2020-07-24 15:35 ` Stephen Hemminger
2020-07-24 16:15 ` [RFT iproute2] iplink_bridge: scale all time values by USER_HZ Stephen Hemminger
2020-07-24 16:24 ` nikolay
2020-07-24 19:05 ` Stephen Hemminger [this message]
2020-07-24 22:51 ` Nikolay Aleksandrov
2020-07-24 23:18 ` Vladimir Oltean
2020-07-25 0:31 ` David Miller
2020-07-26 3:17 ` Stephen Hemminger
2020-07-26 10:43 ` [RFC iproute2] ip: bridge: use -human to convert time-related values to seconds Nikolay Aleksandrov
2020-07-26 16:21 ` Vladimir Oltean
2020-07-26 16:34 ` Nikolay Aleksandrov
2020-07-26 16:50 ` Vladimir Oltean
2020-07-27 16:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724120513.13d4b3b1@hermes.lan \
--to=stephen@networkplumber.org \
--cc=amarao@servers.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).