From: Andrew Lunn <andrew@lunn.ch>
To: Andre.Edich@microchip.com
Cc: Parthiban.Veerasooran@microchip.com, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net
Subject: Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers
Date: Fri, 24 Jul 2020 17:34:45 +0200 [thread overview]
Message-ID: <20200724153445.GG1594328@lunn.ch> (raw)
In-Reply-To: <c2cb789ac1beebc5c337e97c05e462202d19abcf.camel@microchip.com>
> > > +static void smsc95xx_handle_link_change(struct net_device *net)
> > > +{
> > > + phy_print_status(net->phydev);
> >
> > So the MAC does not care about the speed? The pause configuration?
> > Duplex?
>
> Now, I'm wondering how those "care about speed", "pause", and "duplex"
> work in the current smsc95xx. I guess, we did not touch any of those
> activities with our patches.
Yes, this patchset itself is not necessarily wrong. It seems more like
the driver could be broken with respect to these things. It is
something you might want to put on your TODO list to look at later.
Andrew
next prev parent reply other threads:[~2020-07-24 15:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 11:55 [PATCH net-next v2 0/6] Add PAL support to smsc95xx Andre Edich
2020-07-23 11:55 ` [PATCH net-next v2 1/6] smsc95xx: remove redundant function arguments Andre Edich
2020-07-23 11:55 ` [PATCH net-next v2 2/6] smsc95xx: use usbnet->driver_priv Andre Edich
2020-07-23 22:42 ` Andrew Lunn
2020-07-23 11:55 ` [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers Andre Edich
2020-07-23 22:39 ` Andrew Lunn
2020-07-24 15:17 ` Andre.Edich
2020-07-24 15:34 ` Andrew Lunn [this message]
2020-07-25 16:33 ` kernel test robot
2020-07-23 11:55 ` [PATCH net-next v2 4/6] smsc95xx: remove redundant link status checking Andre Edich
2020-07-23 22:41 ` Andrew Lunn
2020-07-23 11:55 ` [PATCH net-next v2 5/6] smsc95xx: use PAL framework read/write functions Andre Edich
2020-07-25 19:30 ` kernel test robot
2020-07-23 11:55 ` [PATCH net-next v2 6/6] smsc95xx: use PHY framework instead of MII library Andre Edich
2020-07-25 23:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724153445.GG1594328@lunn.ch \
--to=andrew@lunn.ch \
--cc=Andre.Edich@microchip.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).