From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA412C433E1 for ; Sun, 26 Jul 2020 09:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A862720719 for ; Sun, 26 Jul 2020 09:46:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Yp1ISqCq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgGZJqc (ORCPT ); Sun, 26 Jul 2020 05:46:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbgGZJqb (ORCPT ); Sun, 26 Jul 2020 05:46:31 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C12C0619D2 for ; Sun, 26 Jul 2020 02:46:31 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a5so2018338wrm.6 for ; Sun, 26 Jul 2020 02:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HQ/IWfLT3mq5cvefu9vsO8j/vu7mJElveg8ExLzFSq4=; b=Yp1ISqCqPjLzOGigDU3wGEPVdHtEU9EELwYtGraV3aP4dSYRCE7EG3AluxlbrAFMeL 2ikm8LqiYr8ETCdYrxdo3+W0ov6Mpy1D2qlU3UkaCV25nIK5fXFNzzCJiJ/RxZl72KS1 Ssivs3GpdfXWHtmEnVa6/WShKBZdoNgSLFl4InEbkhgYVoOaNLJ2GL6QbogDFbMoBOJf I4q3qwsMBw2feZagxUAqXBixfwLkiU2zoZH0aHRW59J7Shtn7+fbYK8ljMAi4nR7lmiD BCPH71qkv++KbRFsKqxLkRx7ePZzxRDh5wCs2awMPhr5tSxwa2js0hKW4tbGDzVN/ES5 cyYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HQ/IWfLT3mq5cvefu9vsO8j/vu7mJElveg8ExLzFSq4=; b=oS1HoRsgr74IIfRD39KOW9uQC6tR1k2DqmmOJs7S8N2J3+TI0DGUTCXesN1Z3BE/hZ JFmxm+bhf/onK4zAAwd/sfQk5rhZAsW7iQC3/hkztlMmuTYkiGu8+9UmOQ7K8+PWNFeX 2pTBTAHJ4Hn/GPNeWWmzU+dboDzLE2VJ2W/vd2o5jksR3wFb1lP5EnqtCSZEBidiSfUV l8U0qF3+TCXAJkAH/Q1CnyyS6jgkUmx9NcqrSnhdLeFj+BGm20qSgRuyGgZVngceTjHC 9uwfWeg+BWsX+Cey7WkbgnhLR1Dh3sMmSVGIAUAlKLTUS1SHZiDBGBmgbEctpuZfH7q6 yEGQ== X-Gm-Message-State: AOAM533q6ZpitlFdhm53+BGiwXIRWdagZNvKumAewhV93zl1/fkoi2at AwD/6SrNwKvJsPqrPHiPL+I0nw== X-Google-Smtp-Source: ABdhPJwxzESIZx5RqrcS487WEPuX23LLzaYS8I3Mph8QE4IavHOTM/EAbjKmH3W16NNw2GoWMYh2jA== X-Received: by 2002:adf:f8d0:: with SMTP id f16mr8319563wrq.66.1595756788685; Sun, 26 Jul 2020 02:46:28 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id o9sm7570528wrs.1.2020.07.26.02.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 02:46:28 -0700 (PDT) Date: Sun, 26 Jul 2020 11:46:27 +0200 From: Jiri Pirko To: Vadym Kochan Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mickey Rachamim Subject: Re: [net-next v3 4/6] net: marvell: prestera: Add ethtool interface support Message-ID: <20200726094627.GG2216@nanopsycho> References: <20200725150651.17029-1-vadym.kochan@plvision.eu> <20200725150651.17029-5-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200725150651.17029-5-vadym.kochan@plvision.eu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Jul 25, 2020 at 05:06:49PM CEST, vadym.kochan@plvision.eu wrote: >The ethtool API provides support for the configuration of the following >features: speed and duplex, auto-negotiation, MDI-x, forward error >correction, port media type. The API also provides information about the >port status, hardware and software statistic. The following limitation >exists: > > - port media type should be configured before speed setting > - ethtool -m option is not supported > - ethtool -p option is not supported > - ethtool -r option is supported for RJ45 port only > - the following combination of parameters is not supported: > > ethtool -s sw1pX port XX autoneg on > > - forward error correction feature is supported only on SFP ports, 10G > speed > > - auto-negotiation and MDI-x features are not supported on > Copper-to-Fiber SFP module > >Signed-off-by: Andrii Savka >Signed-off-by: Serhiy Boiko >Signed-off-by: Vadym Kochan >--- [...] >+ >+void prestera_ethtool_get_stats(struct net_device *dev, >+ struct ethtool_stats *stats, u64 *data) >+{ >+ struct prestera_port *port = netdev_priv(dev); >+ struct prestera_port_stats *port_stats; >+ >+ port_stats = &port->cached_hw_stats.stats; >+ >+ memcpy((u8 *)data, port_stats, sizeof(*port_stats)); Avoid the needless cast. [...] >+static const struct ethtool_ops ethtool_ops = { >+ .get_drvinfo = prestera_ethtool_get_drvinfo, >+ .get_link_ksettings = prestera_ethtool_get_link_ksettings, >+ .set_link_ksettings = prestera_ethtool_set_link_ksettings, >+ .get_fecparam = prestera_ethtool_get_fecparam, >+ .set_fecparam = prestera_ethtool_set_fecparam, >+ .get_sset_count = prestera_ethtool_get_sset_count, >+ .get_strings = prestera_ethtool_get_strings, >+ .get_ethtool_stats = prestera_ethtool_get_stats, >+ .get_link = ethtool_op_get_link, >+ .nway_reset = prestera_ethtool_nway_reset >+}; Have the struct in prestera_ethtool.c and export just the struct instead of all the callbacks. >+ > static int prestera_port_create(struct prestera_switch *sw, u32 id) > { > struct prestera_port *port; >@@ -235,6 +266,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id) > > dev->features |= NETIF_F_NETNS_LOCAL; > dev->netdev_ops = &netdev_ops; >+ dev->ethtool_ops = ðtool_ops; > > netif_carrier_off(dev); > >-- >2.17.1 >