From: Andrew Lunn <andrew@lunn.ch>
To: Ilia Lin <ilial@codeaurora.org>
Cc: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
edumazet@google.com, ap420073@gmail.com,
xiyou.wangcong@gmail.com, maximmi@mellanox.com,
ilia.lin@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dev: Add API to check net_dev readiness
Date: Sun, 26 Jul 2020 21:45:28 +0200 [thread overview]
Message-ID: <20200726194528.GC1661457@lunn.ch> (raw)
In-Reply-To: <1595792274-28580-1-git-send-email-ilial@codeaurora.org>
On Sun, Jul 26, 2020 at 10:37:54PM +0300, Ilia Lin wrote:
> From: Ilia Lin <ilia.lin@kernel.org>
>
> Add an API that returns true, if the net_dev_init was already called,
> and the driver was initialized.
>
> Some early drivers, that are initialized during the subsys_initcall
> may try accessing the net_dev or NAPI APIs before the net_dev_init,
> and will encounter a kernel bug. This API provides a way to handle
> this and manage by deferring or by other way.
Hi Ilia
You need to include a user of this new API.
I also have to wonder why a network device driver is being probed the
subsys_initcall.
Andrew
next prev parent reply other threads:[~2020-07-26 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 19:37 [PATCH] net: dev: Add API to check net_dev readiness Ilia Lin
2020-07-26 19:45 ` Andrew Lunn [this message]
2020-07-27 17:32 ` David Miller
2020-08-04 17:47 ` Ilia Lin
2020-08-04 19:24 ` Andrew Lunn
2020-08-05 10:31 ` Ilia Lin
2020-08-05 13:14 ` Andrew Lunn
2020-08-04 18:42 ` Ilia Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726194528.GC1661457@lunn.ch \
--to=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ilia.lin@kernel.org \
--cc=ilial@codeaurora.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).