From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D53AC433E0 for ; Sun, 26 Jul 2020 23:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B51A20715 for ; Sun, 26 Jul 2020 23:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="KhpW88tp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgGZXtH (ORCPT ); Sun, 26 Jul 2020 19:49:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgGZXtG (ORCPT ); Sun, 26 Jul 2020 19:49:06 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E3F8C0619D2 for ; Sun, 26 Jul 2020 16:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V+ni9toS0qtTzpjW+RmVhfIZ1PFpI327luJuFq60QM8=; b=KhpW88tpIHMuMZLKOR+Zf+3uz ycVyothCkP7eu+nkRDOi6aanbvoKg2Ib8B0EZimJQC5zByQemECAKYseigLL01WeuRoIEkamOxEID fdIt6qDupItET1GhyJEuL8NkTTfxKf2j3iQPdcLAGVKVVJ7wi2fqLcoa+k7MYlbT4KL0rZtbjjIL1 LFm/Y80rkIrBQRotAKWieobVFZmQWaaHJ+YSkjWLQ6HpTkPH+cmF0tgkWZtFrAOV3Bnm91BNULA7Q 3TnAlH+ej+cgREeWJgBFC+0PAJuuNxosYPeDca4EsQI1RvCmYoJsnwKYzk2K/EiEqNdaZ3MP9p9DK NzQpl/bfQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44576) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzqO3-00023B-Hu; Mon, 27 Jul 2020 00:48:59 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jzqO0-00035C-VV; Mon, 27 Jul 2020 00:48:56 +0100 Date: Mon, 27 Jul 2020 00:48:56 +0100 From: Russell King - ARM Linux admin To: Richard Cochran , Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support Message-ID: <20200726234856.GG1551@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 14, 2020 at 05:26:28PM +0100, Russell King wrote: > The driver takes inspiration from the Marvell 88E6xxx DSA and DP83640 > drivers. The hardware is very similar to the implementation found in > the 88E6xxx DSA driver, but the access methods are very different, > although it may be possible to create a library that both can use > along with accessor functions. I think this definitely needs to become a library - I've just been looking at mvneta in Armada 388. One of the three interfaces has PTP support, and it looks like the register set is again very similar to the 88E151x and 88E6xxx PTP/TAI register layouts, but has yet another different access method. We certainly don't want three copies of almost identical code... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!