From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793AEC433E1 for ; Mon, 27 Jul 2020 02:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54E342070A for ; Mon, 27 Jul 2020 02:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726805AbgG0COg (ORCPT ); Sun, 26 Jul 2020 22:14:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56356 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgG0COg (ORCPT ); Sun, 26 Jul 2020 22:14:36 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jzseu-0072b0-2u; Mon, 27 Jul 2020 04:14:32 +0200 Date: Mon, 27 Jul 2020 04:14:32 +0200 From: Andrew Lunn To: Laurent Pinchart Cc: Fugang Duan , davem@davemloft.net, netdev@vger.kernel.org, cphealy@gmail.com, martin.fuzzey@flowbird.group Subject: Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO" Message-ID: <20200727021432.GM1661457@lunn.ch> References: <1587996484-3504-1-git-send-email-fugang.duan@nxp.com> <20200727012354.GT28704@pendragon.ideasonboard.com> <20200727020631.GW28704@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727020631.GW28704@pendragon.ideasonboard.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 27, 2020 at 05:06:31AM +0300, Laurent Pinchart wrote: > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, > > > i.MX8MQ, and i.MX8QXP platforms. Boot yocto system by NFS mounting > > > rootfs will be failed with the commit. > > > > I'm afraid this commit breaks networking on i.MX7D for me :-( My board > > is configured to boot over NFS root with IP autoconfiguration through > > DHCP. The DHCP request goes out, the reply it sent back by the server, > > but never noticed by the fec driver. > > > > v5.7 works fine. As 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef was merged > > during the v5.8 merge window, I suspect something else cropped in > > between 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef and this patch that > > needs to be reverted too. We're close to v5.8 and it would be annoying > > to see this regression ending up in the released kernel. I can test > > patches, but I'm not familiar enough with the driver (or the networking > > subsystem) to fix the issue myself. > > If it can be of any help, I've confirmed that, to get the network back > to usable state from v5.8-rc6, I have to revert all patches up to this > one. This is the top of my branch, on top of v5.8-rc6: > > 5bbe80c9efea Revert "net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"" > 5462896a08c1 Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO" > 824a82e2bdfa Revert "net: ethernet: fec: move GPR register offset and bit into DT" > bfe330591cab Revert "net: fec: disable correct clk in the err path of fec_enet_clk_enable" > 109958cad578 Revert "net: ethernet: fec: prevent tx starvation under high rx load" OK. What PHY are you using? A Micrel? And which DT file? Thanks Andrew