From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason
Date: Mon, 27 Jul 2020 13:47:03 -0700 [thread overview]
Message-ID: <20200727134703.4243db74@hermes.lan> (raw)
In-Reply-To: <1595877677-45849-1-git-send-email-roopa@cumulusnetworks.com>
On Mon, 27 Jul 2020 12:21:17 -0700
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> - + nla_total_size(1) /* IFLA_PROTO_DOWN */
> + + rtnl_proto_down_size(dev) /* proto down */
Changing the size of a netlink field is an ABI change in the kernel.
This has the potential to break existing programs.
Wouldn't it be safer to add a new link attribute for the reason
rather than overloading the existing attribute?
next prev parent reply other threads:[~2020-07-27 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 19:21 [PATCH net-next] rtnetlink: add support for protodown reason Roopa Prabhu
2020-07-27 20:47 ` Stephen Hemminger [this message]
2020-07-27 22:43 ` Roopa Prabhu
2020-07-30 23:38 ` David Miller
2020-07-31 2:59 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727134703.4243db74@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).