From: Richard Cochran <richardcochran@gmail.com>
To: "Ooi, Joyce" <joyce.ooi@intel.com>
Cc: Thor Thayer <thor.thayer@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dalon Westergreen <dalon.westergreen@linux.intel.com>,
Tan Ley Foon <ley.foon.tan@intel.com>,
See Chin Liang <chin.liang.see@intel.com>,
Dinh Nguyen <dinh.nguyen@intel.com>,
Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping
Date: Mon, 27 Jul 2020 07:29:25 -0700 [thread overview]
Message-ID: <20200727142925.GB16836@hoboy> (raw)
In-Reply-To: <20200727092157.115937-9-joyce.ooi@intel.com>
On Mon, Jul 27, 2020 at 05:21:55PM +0800, Ooi, Joyce wrote:
> +/* ioctl to configure timestamping */
> +static int tse_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
> +{
> + struct altera_tse_private *priv = netdev_priv(dev);
> + struct hwtstamp_config config;
> +
> + if (!netif_running(dev))
> + return -EINVAL;
> +
> + if (!priv->has_ptp) {
> + netdev_alert(priv->dev, "Timestamping not supported");
> + return -EOPNOTSUPP;
> + }
The user might well have a PHY that supports time stamping. The code
must pass the ioctl through to the PHY even when !priv->has_ptp.
> +
> + if (!dev->phydev)
> + return -EINVAL;
> +
> + if (!phy_has_hwtstamp(dev->phydev)) {
> + if (cmd == SIOCSHWTSTAMP) {
> + if (copy_from_user(&config, ifr->ifr_data,
> + sizeof(struct hwtstamp_config)))
> + return -EFAULT;
> +
> + if (config.flags)
> + return -EINVAL;
> +
> + switch (config.tx_type) {
> + case HWTSTAMP_TX_OFF:
> + priv->hwts_tx_en = 0;
> + break;
> + case HWTSTAMP_TX_ON:
> + priv->hwts_tx_en = 1;
> + break;
> + default:
> + return -ERANGE;
> + }
> +
> + switch (config.rx_filter) {
> + case HWTSTAMP_FILTER_NONE:
> + priv->hwts_rx_en = 0;
> + config.rx_filter = HWTSTAMP_FILTER_NONE;
> + break;
> + default:
> + priv->hwts_rx_en = 1;
> + config.rx_filter = HWTSTAMP_FILTER_ALL;
> + break;
> + }
> +
> + if (copy_to_user(ifr->ifr_data, &config,
> + sizeof(struct hwtstamp_config)))
> + return -EFAULT;
> + else
> + return 0;
> + }
> +
> + if (cmd == SIOCGHWTSTAMP) {
> + config.flags = 0;
> +
> + if (priv->hwts_tx_en)
> + config.tx_type = HWTSTAMP_TX_ON;
> + else
> + config.tx_type = HWTSTAMP_TX_OFF;
> +
> + if (priv->hwts_rx_en)
> + config.rx_filter = HWTSTAMP_FILTER_ALL;
> + else
> + config.rx_filter = HWTSTAMP_FILTER_NONE;
> +
> + if (copy_to_user(ifr->ifr_data, &config,
> + sizeof(struct hwtstamp_config)))
> + return -EFAULT;
> + else
> + return 0;
> + }
> + }
> +
> + return phy_mii_ioctl(dev->phydev, ifr, cmd);
> +}
Thanks,
Richard
next prev parent reply other threads:[~2020-07-27 14:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:21 [PATCH v5 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 02/10] net: eth: altera: set rx and tx ring size before init_dma call Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 03/10] net: eth: altera: fix altera_dmaops declaration Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 04/10] net: eth: altera: add optional function to start tx dma Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 05/10] net: eth: altera: Move common functions to altera_utils Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 06/10] net: eth: altera: Add missing identifier names to function declarations Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 07/10] net: eth: altera: change tx functions to type netdev_tx_t Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping Ooi, Joyce
2020-07-27 14:29 ` Richard Cochran [this message]
2020-08-07 8:00 ` Ooi, Joyce
2020-07-27 15:54 ` Jakub Kicinski
2020-07-27 16:50 ` kernel test robot
2020-07-27 9:21 ` [PATCH v5 09/10] net: eth: altera: add msgdma prefetcher Ooi, Joyce
2020-07-27 9:21 ` [PATCH v5 10/10] net: eth: altera: update devicetree bindings documentation Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727142925.GB16836@hoboy \
--to=richardcochran@gmail.com \
--cc=chin.liang.see@intel.com \
--cc=dalon.westergreen@intel.com \
--cc=dalon.westergreen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinh.nguyen@intel.com \
--cc=joyce.ooi@intel.com \
--cc=kuba@kernel.org \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).