From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chris Healy <cphealy@gmail.com>,
Fugang Duan <fugang.duan@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Martin Fuzzey <martin.fuzzey@flowbird.group>
Subject: Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"
Date: Mon, 27 Jul 2020 18:24:34 +0300 [thread overview]
Message-ID: <20200727152434.GF20890@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200727120545.GN1661457@lunn.ch>
Hi Andrew,
On Mon, Jul 27, 2020 at 02:05:45PM +0200, Andrew Lunn wrote:
> On Sun, Jul 26, 2020 at 08:01:25PM -0700, Chris Healy wrote:
> > It appears quite a few boards were affected by this micrel PHY driver change:
> >
> > 2ccb0161a0e9eb06f538557d38987e436fc39b8d
> > 80bf72598663496d08b3c0231377db6a99d7fd68
> > 2de00450c0126ec8838f72157577578e85cae5d8
> > 820f8a870f6575acda1bf7f1a03c701c43ed5d79
> >
> > I just updated the phy-mode with my board from rgmii to rgmii-id and
> > everything started working fine with net-next again:
>
> Hi Chris
>
> Is this a mainline supported board? Do you plan to submit a patch?
>
> Laurent, does the change also work for your board? This is another one
> of those cases were a bug in the PHY driver, not respecting the
> phy-mode, has masked a bug in the device tree, using the wrong
> phy-mode. We had the same issue with the Atheros PHY a while back.
Yes, setting the phy-mode to rgmii-id fixes the issue.
Thank you everybody for your quick responses and very useful help !
On a side note, when the kernel boots, there's a ~10s delay for the
ethernet connection to come up:
[ 4.050754] Micrel KSZ9031 Gigabit PHY 30be0000.ethernet-1:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=30be0000.ethernet-1:01, irq=POLL)
[ 15.628528] fec 30be0000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx
[ 15.676961] Sending DHCP requests ., OK
[ 15.720925] IP-Config: Got DHCP answer from 192.168.2.47, my address is 192.168.2.210
The LED on the connected switch confirms this, it lits up synchronously
with the "Link is up" message. It's not an urgent issue, but if someone
had a few pointers on how I could debug that, it would be appreciated.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-27 15:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:08 [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO" Fugang Duan
2020-05-01 3:31 ` David Miller
2020-07-27 1:23 ` Laurent Pinchart
2020-07-27 1:38 ` Andrew Lunn
2020-07-27 2:06 ` Laurent Pinchart
2020-07-27 2:13 ` Chris Healy
2020-07-27 2:21 ` [EXT] " Andy Duan
2020-07-27 2:36 ` Laurent Pinchart
2020-07-27 2:14 ` Andrew Lunn
2020-07-27 2:33 ` Laurent Pinchart
2020-07-27 2:35 ` Chris Healy
2020-07-27 2:39 ` Laurent Pinchart
2020-07-27 2:40 ` Chris Healy
2020-07-27 2:51 ` [EXT] " Andy Duan
2020-07-27 3:01 ` Chris Healy
2020-07-27 3:08 ` [EXT] " Andy Duan
2020-07-27 12:05 ` Andrew Lunn
2020-07-27 13:30 ` Chris Healy
2020-07-27 15:24 ` Laurent Pinchart [this message]
2020-07-27 15:41 ` Chris Healy
2020-07-27 17:37 ` Laurent Pinchart
2020-07-27 18:03 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727152434.GF20890@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=martin.fuzzey@flowbird.group \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).