From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20901C4345D for ; Mon, 27 Jul 2020 23:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1C0320A8B for ; Mon, 27 Jul 2020 23:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892351; bh=bZHxh33PZkH/MAFburC2lqHt5TjiyHUeFr/pGPuH/zU=; h=From:To:Cc:Subject:Date:List-ID:From; b=TRt7Mh5Mg84HbXVwBz7UMU0qnkyRw686n+govqJjlKJbgC/XQ5kJ3Ur0VYJEOOO1h V6Y8NPMKJ5amygHcHM118LdK+flZYSkWpggqQjyX8bD/bYkNpE3ySQmn8TzkcpxSa7 sI0qNgpVPvT6SDGoyxltuLXQaZQMXKMLyW+w8Cz0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbgG0XZt (ORCPT ); Mon, 27 Jul 2020 19:25:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:36816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728629AbgG0XZ1 (ORCPT ); Mon, 27 Jul 2020 19:25:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F2C920A8B; Mon, 27 Jul 2020 23:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892327; bh=bZHxh33PZkH/MAFburC2lqHt5TjiyHUeFr/pGPuH/zU=; h=From:To:Cc:Subject:Date:From; b=WfGBr3a4B3dlxFCeccty/Q1ig54sR8UfWqn9TbiuKMW8jR0WgVi7eFQuzK+mAEy7z NqiZZ9yWsbn/4S00eD9ApWOtvEjkFcCuqHEcrt29R1RS3Kr4JhasDWHWDKts2Z+Jvr mafhSrhmAe3BtTMmdcUT2BFw6N1HTy6NnvTbc+6k= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , "David S . Miller" , Sasha Levin , linux-nfc@lists.01.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 1/4] nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame Date: Mon, 27 Jul 2020 19:25:22 -0400 Message-Id: <20200727232525.718372-1-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Navid Emamdoost [ Upstream commit 1e8fd3a97f2d83a7197876ceb4f37b4c2b00a0f3 ] The implementation of s3fwrn5_recv_frame() is supposed to consume skb on all execution paths. Release skb before returning -ENODEV. Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/nfc/s3fwrn5/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c index 0d866ca295e3f..cafab107ba9bc 100644 --- a/drivers/nfc/s3fwrn5/core.c +++ b/drivers/nfc/s3fwrn5/core.c @@ -209,6 +209,7 @@ int s3fwrn5_recv_frame(struct nci_dev *ndev, struct sk_buff *skb, case S3FWRN5_MODE_FW: return s3fwrn5_fw_recv_frame(ndev, skb); default: + kfree_skb(skb); return -ENODEV; } } -- 2.25.1