From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A8FC433E3 for ; Tue, 28 Jul 2020 06:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7B0A20786 for ; Tue, 28 Jul 2020 06:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbgG1Gud (ORCPT ); Tue, 28 Jul 2020 02:50:33 -0400 Received: from verein.lst.de ([213.95.11.211]:46915 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbgG1Gud (ORCPT ); Tue, 28 Jul 2020 02:50:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AB49E68BEB; Tue, 28 Jul 2020 08:50:29 +0200 (CEST) Date: Tue, 28 Jul 2020 08:50:29 +0200 From: Christoph Hellwig To: Eric Dumazet Cc: Jonathan Lemon , netdev , kernel-team , Christoph Hellwig , Robin Murphy , Andrew Morton , David Miller , Jakub Kicinski , Willem de Bruijn , Steffen Klassert , Saeed Mahameed , Maxim Mikityanskiy , bjorn.topel@intel.com, magnus.karlsson@intel.com, borisp@mellanox.com, david@redhat.com Subject: Re: [RFC PATCH v2 15/21] net/tcp: add MSG_NETDMA flag for sendmsg() Message-ID: <20200728065029.GA21479@lst.de> References: <20200727052846.4070247-1-jonathan.lemon@gmail.com> <20200727052846.4070247-16-jonathan.lemon@gmail.com> <20200727155549.gbwosugbugknsneo@bsd-mbp.dhcp.thefacebook.com> <20200727173528.tfsrweswpyjxlqv6@bsd-mbp.dhcp.thefacebook.com> <20200728021130.bjrlcj7tzebfxsz3@bsd-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 27, 2020 at 07:17:51PM -0700, Eric Dumazet wrote: > > The thing is, the existing zero copy code is zero-copy to /host/ memory, > > which is not the same thing as zero-copy to other memory areas. > > You have to really explain what difference it makes, and why current > stuff can not be extended. There basically is none. You need to call a different dma mapping routine and make sure to never access the device pages. See drivers/pci/p2pdma.c and its users for an example on how to do it properly. But the author wants all his crazy hacks to hook into his proprietary crap, so everyone should be ignore this horrible series.