From: Andrew Lunn <andrew@lunn.ch>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Lars Alex Pedersen <laa@kamstrup.com>,
Bruno Thomsen <bth@kamstrup.com>
Subject: Re: [PATCH 1/2] net: mdiobus: reset deassert delay
Date: Tue, 28 Jul 2020 20:41:42 +0200 [thread overview]
Message-ID: <20200728184142.GA1745134@lunn.ch> (raw)
In-Reply-To: <20200728090203.17313-1-bruno.thomsen@gmail.com>
On Tue, Jul 28, 2020 at 11:02:02AM +0200, Bruno Thomsen wrote:
> The current reset logic only has a delay during assert.
> This reuses the delay value as deassert delay to ensure
> PHYs are ready for commands. Delays are typically needed
> when external hardware slows down reset release with a
> RC network. This solution does not need any new device
> tree bindings.
> It also improves handling of long delays (>20ms) by using
> the generic fsleep() for selecting appropriate delay
> function.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Hi Bruno
In netdev, it is normal to include a [patch 0/2] for a patchset which
explains the big picture. Also, please use [patch net-next ..] to
indicate this is for the net-next tree. If you think these are fixes
for stable, please base them on net, and use [patch net ..], and
include Fixes: tags.
Andrew
prev parent reply other threads:[~2020-07-28 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:02 [PATCH 1/2] net: mdiobus: reset deassert delay Bruno Thomsen
2020-07-28 9:02 ` [PATCH 2/2] dt-bindings: net: mdio: update reset-delay-us description Bruno Thomsen
2020-07-28 12:32 ` [PATCH 1/2] net: mdiobus: reset deassert delay Fabio Estevam
2020-07-28 12:49 ` Bruno Thomsen
2020-07-28 18:47 ` Andrew Lunn
2020-07-28 18:41 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728184142.GA1745134@lunn.ch \
--to=andrew@lunn.ch \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=laa@kamstrup.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).