From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
jiri@mellanox.com, kernel-team@fb.com
Subject: Re: [PATCH net] devlink: ignore -EOPNOTSUPP errors on dumpit
Date: Wed, 29 Jul 2020 10:21:29 +0200 [thread overview]
Message-ID: <20200729082129.GA2204@nanopsycho> (raw)
In-Reply-To: <20200728231507.426387-1-kuba@kernel.org>
Wed, Jul 29, 2020 at 01:15:07AM CEST, kuba@kernel.org wrote:
>Number of .dumpit functions try to ignore -EOPNOTSUPP errors.
>Recent change missed that, and started reporting all errors
>but -EMSGSIZE back from dumps. This leads to situation like
>this:
>
>$ devlink dev info
>devlink answers: Operation not supported
>
>Dump should not report an error just because the last device
>to be queried could not provide an answer.
>
>To fix this and avoid similar confusion make sure we clear
>err properly, and not leave it set to an error if we don't
>terminate the iteration.
>
>Fixes: c62c2cfb801b ("net: devlink: don't ignore errors during dumpit")
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Yeah, that makes perfect sense. Thanks for the fix Kuba!
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2020-07-29 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 23:15 [PATCH net] devlink: ignore -EOPNOTSUPP errors on dumpit Jakub Kicinski
2020-07-28 23:21 ` Jacob Keller
2020-07-29 8:21 ` Jiri Pirko [this message]
2020-07-30 23:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729082129.GA2204@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).