From: Jiri Pirko <jiri@resnulli.us>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ariel Elior <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>,
Alexander Lobakin <alobakin@marvell.com>,
Michal Kalderon <michal.kalderon@marvell.com>
Subject: Re: [PATCH v3 net-next 03/11] qed: swap param init and publish
Date: Wed, 29 Jul 2020 14:51:02 +0200 [thread overview]
Message-ID: <20200729125102.GC2204@nanopsycho> (raw)
In-Reply-To: <20200729113846.1551-4-irusskikh@marvell.com>
Wed, Jul 29, 2020 at 01:38:38PM CEST, irusskikh@marvell.com wrote:
>In theory that could lead to race condition
Describe the problem, tell the codebase what to do.
Plus, this looks like a -net material. Please consider pushing this
separatelly with proper "fixes" tag.
>
>Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>Signed-off-by: Alexander Lobakin <alobakin@marvell.com>
>Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
>---
> drivers/net/ethernet/qlogic/qed/qed_devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
>index a62c47c61edf..4e3316c6beb6 100644
>--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c
>+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
>@@ -75,8 +75,8 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
> QED_DEVLINK_PARAM_ID_IWARP_CMT,
> value);
>
>- devlink_params_publish(dl);
> cdev->iwarp_cmt = false;
>+ devlink_params_publish(dl);
>
> return dl;
>
>--
>2.17.1
>
next prev parent reply other threads:[~2020-07-29 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 11:38 [PATCH v3 net-next 00/11] qed: introduce devlink health support Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 01/11] qed: move out devlink logic into a new file Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 02/11] qed/qede: make devlink survive recovery Igor Russkikh
2020-07-29 12:49 ` Jiri Pirko
2020-07-29 11:38 ` [PATCH v3 net-next 03/11] qed: swap param init and publish Igor Russkikh
2020-07-29 12:51 ` Jiri Pirko [this message]
2020-07-29 11:38 ` [PATCH v3 net-next 04/11] qed: fix kconfig help entries Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 05/11] qed: implement devlink info request Igor Russkikh
2020-07-29 12:52 ` Jiri Pirko
2020-07-29 11:38 ` [PATCH v3 net-next 06/11] qed: health reporter init deinit seq Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 07/11] qed: use devlink logic to report errors Igor Russkikh
2020-07-29 13:08 ` Jiri Pirko
2020-07-30 8:30 ` [EXT] " Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 08/11] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 09/11] qed: implement devlink dump Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 10/11] qed: align adjacent indent Igor Russkikh
2020-07-29 11:38 ` [PATCH v3 net-next 11/11] qede: make driver reliable on unload after failures Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729125102.GC2204@nanopsycho \
--to=jiri@resnulli.us \
--cc=aelior@marvell.com \
--cc=alobakin@marvell.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).