From: Richard Cochran <richardcochran@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Petr Machata <petrm@mellanox.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Samuel Zou <zou_wei@huawei.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 4/9] mlxsw: spectrum_ptp: Use generic helper function
Date: Wed, 29 Jul 2020 06:49:58 -0700 [thread overview]
Message-ID: <20200729134958.GC23222@hoboy> (raw)
In-Reply-To: <87sgdaaa2z.fsf@kurt>
On Wed, Jul 29, 2020 at 12:29:08PM +0200, Kurt Kanzenbach wrote:
> I'll test it and send v3. But before, I've got another question that
> somebody might have an answer to:
>
> The ptp v1 code always does locate the message type at
>
> msgtype = data + offset + OFF_PTP_CONTROL
>
> OFF_PTP_CONTROL is 32. However, looking at the ptp v1 header, the
> message type is located at offset 20. What am I missing here?
My source back in the day was the John Eidson book. In Appendix A it claims
Table A.1. Common PTP message fields
Field name Purpose
--------------------------------------------------------------------
messageType Identifies message as event or general
control Indicates the message type, e.g., Sync
So I think the code is correct.
Thanks,
Richard
next prev parent reply other threads:[~2020-07-29 13:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:05 [PATCH v2 0/9] ptp: Add generic header parsing function Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 1/9] ptp: Add generic ptp v2 " Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 2/9] ptp: Add generic ptp message type function Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 3/9] net: dsa: mv88e6xxx: Use generic helper function Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 4/9] mlxsw: spectrum_ptp: " Kurt Kanzenbach
2020-07-27 13:00 ` Petr Machata
2020-07-28 13:29 ` Kurt Kanzenbach
2020-07-28 13:41 ` Kurt Kanzenbach
2020-07-28 21:06 ` Petr Machata
2020-07-29 10:02 ` Russell King - ARM Linux admin
2020-07-29 10:29 ` Kurt Kanzenbach
2020-07-29 13:49 ` Richard Cochran [this message]
2020-07-29 14:26 ` Kurt Kanzenbach
2020-07-29 14:07 ` Petr Machata
2020-07-29 13:22 ` Richard Cochran
2020-07-29 12:23 ` Grygorii Strashko
2020-07-27 9:05 ` [PATCH v2 5/9] ethernet: ti: am65-cpts: " Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 6/9] ethernet: ti: cpts: " Kurt Kanzenbach
2020-07-27 9:05 ` [PATCH v2 7/9] net: phy: dp83640: " Kurt Kanzenbach
2020-07-27 9:06 ` [PATCH v2 8/9] ptp: ptp_ines: " Kurt Kanzenbach
2020-07-27 9:06 ` [PATCH v2 9/9] ptp: Remove unused macro Kurt Kanzenbach
2020-07-29 0:47 ` [PATCH v2 0/9] ptp: Add generic header parsing function David Miller
2020-07-29 9:31 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729134958.GC23222@hoboy \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=vivien.didelot@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).