From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E15C433DF for ; Thu, 30 Jul 2020 11:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5364C20842 for ; Thu, 30 Jul 2020 11:06:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FdJueyYo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbgG3LGX (ORCPT ); Thu, 30 Jul 2020 07:06:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbgG3LGW (ORCPT ); Thu, 30 Jul 2020 07:06:22 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265F4C061794 for ; Thu, 30 Jul 2020 04:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kYVLACyCu5tq8GYC/ZrfewrJhwW2VL5IdvavqD027eE=; b=FdJueyYon+O+q3qCluSAPc5Mg ZBODr/7R2VvC9cQDd43tG5djhj7PCjFecoh1SFIqSq6QVmUctbQpVwwVB+fQhyBSwAD6c3JHgJcXl k3Op4+3sS/X5y9shJN9nspWacYhVrKCnwtHNTGjG1qchauu0z2MgD0TkwDDXN28lROq6zJZcsNW6+ +xdNhZn2qcJIZAb98287y/ZBhFQmiJY7OvB2BE6NYa7Q6KR0kg4JLaiMMyuPzNiXQMrhunSVfqVLl F17jP0xGwXC8gZXJU9nQeXXY8s1ix0yNhE/ejPNVbSCKLIbKevfpVzd82CN/V11nME4dQFEhX0DMY pm+Kt3Stw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46070) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k16O9-0006LI-0O; Thu, 30 Jul 2020 12:06:17 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1k16O6-0006gt-3P; Thu, 30 Jul 2020 12:06:14 +0100 Date: Thu, 30 Jul 2020 12:06:14 +0100 From: Russell King - ARM Linux admin To: Richard Cochran Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support [multicast/DSA issues] Message-ID: <20200730110613.GC1551@shell.armlinux.org.uk> References: <20200729105807.GZ1551@shell.armlinux.org.uk> <20200729131932.GA23222@hoboy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729131932.GA23222@hoboy> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 29, 2020 at 06:19:32AM -0700, Richard Cochran wrote: > On Wed, Jul 29, 2020 at 11:58:07AM +0100, Russell King - ARM Linux admin wrote: > > How do we deal with this situation - from what I can see from the > > ethtool API, we have to make a choice about which to use. How do we > > make that choice? > > Unfortunately the stack does not implement simultaneous MAC + PHY time > stamping. If your board has both, then you make the choice to use the > PHY by selecting NETWORK_PHY_TIMESTAMPING at kernel compile time. > > (Also some MAC drivers do not defer to the PHY properly. Sometimes > you can work around that by de-selecting the MAC's PTP function in the > Kconfig if possible, but otherwise you need to patch the MAC driver.) > > > Do we need a property to indicate whether we wish to use the PHY > > or MAC PTP stamping, or something more elaborate? > > To do this at run time would require quite some work, I expect. Okay, I'm falling into horrible multicast issues with DSA switches while trying to test. Some of my platforms have IP_MULTICAST=y, others have IP_MULTICAST=n. This causes some to send IGMP messages when binding to the multicast address, others do not. Those that do cause the DSA switch to add a static database entry causing all traffic for that multicast address to be only directed to the port(s) that the machine(s) with IP_MULTICAST=y kernels are connected to, depriving all IP_MULTICAST=n machines from seeing those packets. Maybe, with modern networking technology, it's about time that the kernel configuration help recommended that kernels should be built with IP_MULTICAST=y ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!