From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>, netdev <netdev@vger.kernel.org>,
mathew.j.martineau@linux.intel.com,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 05/10] tcp: pass want_cookie down to req_init function
Date: Thu, 30 Jul 2020 19:58:43 +0200 [thread overview]
Message-ID: <20200730175843.GD5271@breakpoint.cc> (raw)
In-Reply-To: <CANn89iKK1Fk7q8dM-s-Pt74D_s7J5UCwA-dTUMbimpEuXj2PSQ@mail.gmail.com>
Eric Dumazet <edumazet@google.com> wrote:
> On Thu, Jul 30, 2020 at 10:15 AM Florian Westphal <fw@strlen.de> wrote:
> >
> > In MPTCP case, we want to know if we should store a new token id or if we
> > should try best-effort only (cookie case).
> >
> > This allows the MPTCP core to detect when it should elide the storage
> > of the generated MPTCP token.
> >
>
> It seems you add later another patch, introducing cookie_tcp_reqsk_alloc()
>
> We could rename req->cookie_ts bit to req->syncookie in order to not
> change function signatures.
Ok, I will update patch #1 to do a rename instead of removing cookie_ts
bit. I will keep the change in output path to check synack_type instead
of cookie_ts.
next prev parent reply other threads:[~2020-07-30 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 17:15 [PATCH net-next 00/10] mptcp: add syncookie support Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 01/10] tcp: remove cookie_ts bit from request_sock Florian Westphal
2020-07-30 17:25 ` Eric Dumazet
2020-07-30 17:15 ` [PATCH net-next 02/10] mptcp: token: move retry to caller Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 03/10] mptcp: subflow: split subflow_init_req Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 04/10] mptcp: rename and export mptcp_subflow_request_sock_ops Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 05/10] tcp: pass want_cookie down to req_init function Florian Westphal
2020-07-30 17:38 ` Eric Dumazet
2020-07-30 17:58 ` Florian Westphal [this message]
2020-07-30 17:15 ` [PATCH net-next 06/10] mptcp: subflow: add mptcp_subflow_init_cookie_req helper Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 07/10] tcp: syncookies: create mptcp request socket for ACK cookies with MPTCP option Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 08/10] mptcp: enable JOIN requests even if cookies are in use Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 09/10] selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally Florian Westphal
2020-07-30 17:15 ` [PATCH net-next 10/10] selftests: mptcp: add test cases for mptcp join tests with syn cookies Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730175843.GD5271@breakpoint.cc \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).