From: Andrew Lunn <andrew@lunn.ch>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups
Date: Sun, 2 Aug 2020 15:49:36 +0200 [thread overview]
Message-ID: <20200802134936.GC1862409@lunn.ch> (raw)
In-Reply-To: <20200802131452.GA2321@mx-linux-amd>
> Did you apply patch 2/2 of the patchset?
> Because version-printing (and the need for a version string) was removed
> from lib8390.c in patch 2/2 to allow the replacement of said
> version-string with MODULE_* macros in 8390.c, and failing to do so whould result
> in the exact same error.
Hi Armin
We require that there be no break in buildability. The kernel must
always build. Otherwise git bisect becomes much more difficult to use.
Andrew
prev parent reply other threads:[~2020-08-02 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 20:52 [PATCH 1/2 v2 net-next] 8390: Miscellaneous cleanups Armin Wolf
2020-08-02 4:32 ` Jakub Kicinski
2020-08-02 13:14 ` Armin Wolf
2020-08-02 13:49 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802134936.GC1862409@lunn.ch \
--to=andrew@lunn.ch \
--cc=W_Armin@gmx.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).